[backport/1.24] ci: use host docker gid for envoybuild (#23803)#23819
Closed
phlax wants to merge 1 commit intoenvoyproxy:release/v1.24from
Closed
[backport/1.24] ci: use host docker gid for envoybuild (#23803)#23819phlax wants to merge 1 commit intoenvoyproxy:release/v1.24from
phlax wants to merge 1 commit intoenvoyproxy:release/v1.24from
Conversation
Previously `/var/run/docker.sock` is readable/writable inside docker run because group ID of `envoygroup` coincidentally matches host docker group, while it is no longer true during rolling out new image. Fixing that by forcing `envoygroup` has host docker group ID. Risk Level: Low Testing: CI Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
cc @lizan |
Member
Author
|
unblock #23817 |
Member
Author
|
arggh - it needs both fixes to pass CI - ill merge the PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
/var/run/docker.sockis readable/writable inside docker run because group ID ofenvoygroupcoincidentally matches host docker group, while it is no longer true during rolling out new image. Fixing that by forcingenvoygrouphas host docker group ID.Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:
Platform Specific Features:
Signed-off-by: Lizan Zhou lizan@tetrate.io
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]