build: making alwayslink optional in Enovy CC libraries#23676
Merged
alyssawilk merged 9 commits intoenvoyproxy:mainfrom Nov 1, 2022
Merged
build: making alwayslink optional in Enovy CC libraries#23676alyssawilk merged 9 commits intoenvoyproxy:mainfrom
alyssawilk merged 9 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
adisuissa,
ggreenway,
htuch,
kyessenov,
lizan,
mattklein123,
wbpcode and
zuercher
as code owners
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
cc @keith I really want to run one of the Envoy builds with this true and I'm not sure how to do that. Ideas? |
alyssawilk
force-pushed
the
noalwayslink
branch
from
a9e9011 to
93fabeb
Compare
Member
|
I don't follow, do you mean you want to run the binary, or CI, and do you mean envoy or envoy mobile? |
Contributor
Author
|
I want to run one of the Envoy CIs with LIBRARY_DEFAULT_ALWAYSLINK = 0 |
alyssawilk
changed the title
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
keith
reviewed
Oct 27, 2022
bazel/envoy_library.bzl
Outdated
| deps += tcmalloc_external_deps(repository) | ||
| # If alwayslink is not specified, allow turning it off via --define=library_autolink=disabled | ||
| # alwayslink is defaulted on for envoy_cc_extensions to ensure the REGISTRY macros work. | ||
| if not(alwayslink): |
Member
There was a problem hiding this comment.
huh, i've never seen this one. this is still false if the call site passes 0 right?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
keith
reviewed
Oct 27, 2022
bazel/envoy_library.bzl
Outdated
|
|
||
| # If alwayslink is not specified, allow turning it off via --define=library_autolink=disabled | ||
| # alwayslink is defaulted on for envoy_cc_extensions to ensure the REGISTRY macros work. | ||
| if not (alwayslink): |
Member
There was a problem hiding this comment.
if this is just the normal not keyword I think we need to check against None explicitly, otherwise I think 0 will be false-y
Suggested change
| if not (alwayslink): | |
| if alwayslink == None: |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
keith
approved these changes
Nov 1, 2022
alyssawilk
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Nov 2, 2022
Fixing issue merging in envoyproxy/envoy#23676 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
dubious90
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Nov 7, 2022
- Still good: - ci/run_envoy_docker.sh - tools/gen_compilation_database.py - python requirements - `LEGACY_ALWAYSLINK` is needed after envoyproxy/envoy#23676 Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Fixing issue merging in #23676 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a variable to change Envoy library defaults to not always link, while fixing up Envoy libraries using singletons and factory registrations to still always link.
Risk Level: high
Testing: using existing tests
Docs Changes: n/a
Release Notes: yes
Platform Specific Features: no
Part of envoyproxy/envoy-mobile#175