utility: Update gdb script so gdb runs well in emacs gud package#2367
Closed
jmarantz wants to merge 5 commits intoenvoyproxy:masterfrom
Closed
utility: Update gdb script so gdb runs well in emacs gud package#2367jmarantz wants to merge 5 commits intoenvoyproxy:masterfrom
jmarantz wants to merge 5 commits intoenvoyproxy:masterfrom
Conversation
to the other handlers with a browser. Add a private mechanism to have admin handlers supply arbitrary headers. Note that the handler callback doesn't expose a header structure, so the public v2 API does not provide this header-control. However, it was specifying text/html as content-type by default, so I changed the default to text/plain (with nosniff). Added sanitization of both the prefix string and the help text, which need to be safely injected into the HTML doc. Added some styling and a reference to the existing Envoy favicon as well. Note that no existing handlers get any response bytes changed as a result of this commit, just their content-type. Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ms in particular. Signed-off-by: Joshua Marantz <jmarantz@google.com>
… can set the content-type and/or cache-control. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
|
@jmarantz the dreaded DCO awaits. |
Contributor
Author
|
urk. I finally figured out how to make a second independent client and didn't realize I need to separately set up hooks for each new client. I'm just going to close this PR and start again :) |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
…#2367) * wip * Use field separator and valueseparator with traffic direction * add stat_prefix * update populateInfo * use . in the separator to make intern table happy * update proto options to parse all Caps fields * remove code related to port mapping * Update separator to use a . and use new localNodeExtractor * format * remove tests related to port mapping * Use envoy that works * update to new API * fix build break
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
These are already being filtered out of our stats inclusion list, so this isn't a user-facing change, but this is needed to support the singleton removal work in envoyproxy/envoy-mobile#2129. Splitting this out into its own PR to reduce the scope of the singleton removal change. Co-authored-by: alyssawilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
These are already being filtered out of our stats inclusion list, so this isn't a user-facing change, but this is needed to support the singleton removal work in envoyproxy/envoy-mobile#2129. Splitting this out into its own PR to reduce the scope of the singleton removal change. Co-authored-by: alyssawilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.