repo: Improve key signing of binaries#23640
Merged
phlax merged 4 commits intoenvoyproxy:mainfrom Nov 3, 2022
Merged
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
Member
Author
|
@mattklein123 as soon as this lands we will need to update the keys to match the changed expectations |
mattklein123
previously approved these changes
Nov 1, 2022
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Just follow up with me in Slack and let me know what we need to do?
mattklein123
approved these changes
Nov 3, 2022
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Nov 8, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Nov 8, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Nov 8, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Nov 9, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]