Skip to content

repo: Release 1.24.0#23542

Closed
wrowe wants to merge 2 commits intoenvoyproxy:mainfrom
wrowe:release-1.24.0
Closed

repo: Release 1.24.0#23542
wrowe wants to merge 2 commits intoenvoyproxy:mainfrom
wrowe:release-1.24.0

Conversation

@wrowe
Copy link
Copy Markdown
Contributor

@wrowe wrowe commented Oct 18, 2022

Signed-off-by: William A Rowe Jr wrowe@vmware.com

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 18, 2022

strange - not sure why format check failed (... seems transient)

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23542 (comment) was created by @phlax.

see: more, trace.

phlax
phlax previously approved these changes Oct 18, 2022
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @wrowe

Comment thread docs/versions.yaml
"1.22": 1.22.2
"1.20": 1.20.7
"1.21": 1.21.5
"1.22": 1.22.5
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlax One question; why is 1.23.2 missing here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The website repo was never updated for 1.23.1 and hasn't been updated for 1.23.2

https://github.com/envoyproxy/envoy-website/blob/main/_config.yml#L23

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep - i must get round to automating that version number as it is often overlooked

in this case we can probably just jump straight to 1.24.0 once this lands

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlax One question; why is 1.23.2 missing here?

good question - it doesnt seem to have a 1.23.x entry at all - ill check further

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why it didnt include first time around - but running it locally - it does seem to add the expected version

diff --git a/docs/versions.yaml b/docs/versions.yaml
index 2335d2019d..202855aa27 100644
--- a/docs/versions.yaml
+++ b/docs/versions.yaml
@@ -13,6 +13,7 @@
 "1.17": 1.17.4
 "1.18": 1.18.4
 "1.19": 1.19.5
-"1.20": 1.20.6
-"1.21": 1.21.4
-"1.22": 1.22.2
+"1.20": 1.20.7
+"1.21": 1.21.5
+"1.22": 1.22.5
+"1.23": 1.23.2

the relevant objects.inv is also added

can you try removing the commit and running the tool again

@wrowe
Copy link
Copy Markdown
Contributor Author

wrowe commented Oct 19, 2022

Replaced with #23561

@wrowe wrowe closed this Oct 19, 2022
@wrowe wrowe deleted the release-1.24.0 branch October 19, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants