Skip to content

doc: fix FAQ doc for route match #23513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 2 commits into from
Oct 17, 2022
+3 −3
Merged

doc: fix FAQ doc for route match #23513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb100d6
doc: fix FAQ doc for strip_matching_host_port
soulxu Oct 17, 2022
df95d6a
fix link
soulxu Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/root/faq/debugging/why_is_my_route_not_found.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ to
- "www.host.com:80"
- "www.host.com:443"

The other is to strip ports entirely using :ref:`stripping port from host header <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.strip_matching_host_port>`. Not that this will only stip port 80 from insecure requests and 443 from secure request. It does
not just stop ports when routes are matched, but changes
the host sent downstream to also not include the port.
The other is to strip ports entirely using :ref:`strip_any_host_port <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.strip_any_host_port>` or
:ref:`strip_matching_host_port <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.strip_matching_host_port>`. The diffent is :ref:`strip_matching_host_port <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.strip_matching_host_port>`
only strip port if it is equal to the listener's local port.