Skip to content

deps: fix mismatch release date in OpenCensus Proto#23220

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
zhxie:fix-23219
Sep 23, 2022
Merged

deps: fix mismatch release date in OpenCensus Proto#23220
phlax merged 1 commit intoenvoyproxy:mainfrom
zhxie:fix-23219

Conversation

@zhxie
Copy link
Copy Markdown
Contributor

@zhxie zhxie commented Sep 23, 2022

Signed-off-by: Xie Zhihao zhihao.xie@intel.com

Commit Message: deps: fix mismatch release date in OpenCensus Proto
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #23219

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Sep 23, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #23220 was opened by zhxie.

see: more, trace.

@zhxie
Copy link
Copy Markdown
Contributor Author

zhxie commented Sep 23, 2022

It is strange why the commit and SHA stays unchanged while the release date of the version changes.
Shall we change the way getting release date by the commit date instead of the GitHub release date here to avoid happening again?

CC @phlax

@phlax
Copy link
Copy Markdown
Member

phlax commented Sep 23, 2022

Shall we change the way getting release date by the commit date instead of the GitHub release date

i think the commit date is harder to track - not sure why the release date changed here - im guessing they must have pulled the release and republished

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @zhxie

/lgtm deps

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 23, 2022
@phlax phlax merged commit b1f5e92 into envoyproxy:main Sep 23, 2022
@zhxie zhxie deleted the fix-23219 branch September 23, 2022 15:20
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 8, 2022
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
wbpcode pushed a commit to wbpcode/envoy that referenced this pull request Nov 10, 2022
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 11, 2022
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Nov 15, 2022
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Feb 4, 2023
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: mismatch release date in opencensus_proto

3 participants