-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add path_matcher + prefix_rewrite validation #23160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adisuissa
merged 270 commits into
envoyproxy:main
from
silverstar194:pattern_template-prefix_rewrite-fix
Sep 19, 2022
Merged
Changes from all commits
Commits
Show all changes
270 commits
Select commit
Hold shift + click to select a range
e14d4d6
Adding TypedExtensionConfig
silverstar194 4846099
Incremental Change
silverstar194 e8c5a9c
Merge remote-tracking branch 'origin/rewrite-extention-lib' into rout…
silverstar194 1405a3c
Merge branch 'main' into rewrite-extention-lib
silverstar194 e3cb859
Added import
silverstar194 9314a34
Merge remote-tracking branch 'origin/rewrite-extention-lib' into rewr…
silverstar194 db9aa98
Style and formatting
silverstar194 03fc99b
Spelling
silverstar194 b4a840b
Added import
silverstar194 cf26d41
Style
silverstar194 f493c54
Style
silverstar194 3543c89
Added string words
silverstar194 910f0a1
Change extension name
silverstar194 75a8e66
Change import
silverstar194 be8991e
Changed extension name
silverstar194 c6b511d
Added import
silverstar194 7c4ec0a
Changed title
silverstar194 5ee9933
Separate extension into two
silverstar194 2466c3d
Merge remote-tracking branch 'origin/rewrite-extention-duel' into rou…
silverstar194 75beba0
Cleaned up code
silverstar194 dc8bae1
Proto changes for pattern template
silverstar194 2dadf3d
Proto changes for pattern template
silverstar194 cb86b2c
Proto changes for pattern template
silverstar194 ed0b7e9
Merge branch 'main' into pattern-template-extention-proto
silverstar194 1990651
docs: Cleanup more literals in API docs (#22174)
silverstar194 403349a
Add space
silverstar194 e7d3877
Spelling
silverstar194 37c854a
Small style and grammar changes
silverstar194 41658a0
Change spacing
silverstar194 66d25b2
Remove proto
silverstar194 97d5b48
Removed old test
silverstar194 fb5e3ce
Merge branch 'pattern-template-extention-proto' into rewrite-extentio…
silverstar194 a85f7ba
Merge branch 'rewrite-extention-lib' into router-filter-matching-lib-…
silverstar194 239ef6a
Moved proto inside extension
silverstar194 f1ea5bf
Merge branch 'rewrite-extention-lib' into router-filter-matching-lib-…
silverstar194 662047a
Start towards generalizing pattern_match -> path_match
silverstar194 93fe32d
Add code coverage
silverstar194 53560e3
Add code coverage
silverstar194 32a5222
Revert test
silverstar194 40e84b4
Reformat
silverstar194 94aa0e7
Reformat
silverstar194 c943a59
Progress towards two extensions
silverstar194 b999215
Progress towards two extensions
silverstar194 12045ae
Remove old test
silverstar194 ec3c28b
Changes towards two extensions
silverstar194 0eff418
Format
silverstar194 38b9220
Added comments
silverstar194 2865e4b
Small changes
silverstar194 a4d9124
Small changes
silverstar194 cbb117d
Change extension format
silverstar194 9714c7a
Change extension format BUILDS
silverstar194 ebd39a3
Fix package name
silverstar194 1967be1
Fix build paths
silverstar194 b9f6c70
Fix build paths
silverstar194 fb72d96
Fix build paths
silverstar194 d9bf653
Merge branch 'pattern-template-extention-proto' into router-filter-ma…
silverstar194 6277e91
Change extension paths
silverstar194 a728038
Work to merge
silverstar194 6d1611d
Work to merge
silverstar194 eda37b8
Work to merge
silverstar194 f4c353a
Add progress
silverstar194 659898d
Add comments
silverstar194 989642f
Changed path
silverstar194 c66c650
Merge branch 'pattern-template-extention-proto' into router-filter-ma…
silverstar194 b149526
Merge in main
silverstar194 ae227c6
Merge branch 'main' into router-filter-matching-lib-control-plane
silverstar194 f25cbc0
Simple changes
silverstar194 c1baccc
Add and pass tests
silverstar194 6ac59da
Small change to test
silverstar194 6d3160b
Small change to test
silverstar194 3a18905
Format and clean up code
silverstar194 fbeca1a
Clean up
silverstar194 fa7d61b
Clean up
silverstar194 82b85bd
Merge remote-tracking branch 'upstream/main' into url-pattern-rewrite…
silverstar194 dea34c2
Clean up
silverstar194 854b14a
Clean up
silverstar194 d157327
Clean up
silverstar194 437eae7
Clean up
silverstar194 7cad22b
To string_view
silverstar194 386d5d2
To string_view
silverstar194 abbadb0
Small changes
silverstar194 93a0a2c
Small changes
silverstar194 b6504c7
Small changes
silverstar194 1366abd
Add pattern lib
silverstar194 792a8a6
Add pattern lib tests
silverstar194 34764c0
Small formatting issues
silverstar194 aea5007
Small formatting issues
silverstar194 0e78b03
Remove proto title
silverstar194 75b3a0c
Add owners
silverstar194 bd7081c
Add owners
silverstar194 94d146c
Changed owner to alyssawilk
silverstar194 42fb15c
Grammer changes
silverstar194 c280b13
Grammer changes
silverstar194 989959a
Grammer changes
silverstar194 0dae2f1
Grammer changes
silverstar194 5bcebeb
Grammar changes
silverstar194 306271a
Merge in rewrite-match-extension-lib
silverstar194 8c141c9
Merge remote-tracking branch 'origin/url-pattern-rewrite-add-extensio…
silverstar194 0825db3
Checkpoint changes
silverstar194 00848b1
Checkpoint changes
silverstar194 fc9f2ea
Checkpoint changes
silverstar194 3d8cc7b
Remove unused tests
silverstar194 a974d09
Casing changes
silverstar194 985538d
Merge remote-tracking branch 'upstream/main' into router-filter-match…
silverstar194 1f57b54
Run format
silverstar194 1e6ca9d
Changed extensions_metadata.yaml
silverstar194 6eacf89
Format and refactor
silverstar194 f101cbf
Format and refactor
silverstar194 598e5c9
Added to exclude
silverstar194 4c00b52
Added to exclude
silverstar194 561d696
Added to exclude
silverstar194 9226da3
Add extension label
silverstar194 63e8be8
Changed doc strings and name
silverstar194 655d054
Changed doc strings and name
silverstar194 35f452d
Spacing
silverstar194 d993ae4
Ordering
silverstar194 b0cd6b2
Add output
silverstar194 d897f24
Edit script
silverstar194 bb2c540
Remove unneeded files
silverstar194 f37852d
Add stubs
silverstar194 d44dbb8
Addressed some comments
silverstar194 1020d4a
Handled error path
silverstar194 5821840
Format
silverstar194 662fa35
Format
silverstar194 697c145
Format
silverstar194 54473ad
Format
silverstar194 0320a5e
Reformat validations
silverstar194 433b9b6
Remove unneeded factory class member
silverstar194 16d88c2
Add config tests
silverstar194 7e5a785
Add library tests
silverstar194 c35f599
Format tests
silverstar194 9fae620
Address some comments
silverstar194 5d1b98e
Adding more tests
silverstar194 c98799a
Refactor internal method and add tests
silverstar194 c65868c
Small changes for comments
silverstar194 60121ec
Merge remote-tracking branch 'upstream/main' into router-filter-match…
silverstar194 8d9f034
Small reorder
silverstar194 081cf8e
Added comment
silverstar194 8ff74df
Added commit
silverstar194 b11c7e3
Added commit
silverstar194 da94ae2
Rename path_match_policy and path_rewrite_policy
silverstar194 5314441
Formating
silverstar194 606932d
added config_test
silverstar194 7770a35
Match and Rewrite Library
silverstar194 cb56566
Add formatting
silverstar194 70c4852
Merge remote-tracking branch 'upstream/main' into rewrite-match-lib
silverstar194 2b84780
Add formatting
silverstar194 3ac78ba
Add code owners
silverstar194 1574273
Changes for comments
silverstar194 d2cf6f7
Add some tests
silverstar194 5525bc8
Add coverage threshold
silverstar194 e930ee9
Add coverage threshold
silverstar194 200fc40
Add coverage threshold
silverstar194 7be7de6
Spelling
silverstar194 af6402c
Formating
silverstar194 a036811
Formating
silverstar194 796d861
Format
silverstar194 1133f8f
Coverage
silverstar194 ef6ab4f
Addresses comments
silverstar194 5438e13
Added more tests
silverstar194 fa27801
Change casing
silverstar194 68d22dc
Merge master
silverstar194 516a086
Unformat
silverstar194 73cf215
Change over to string_view
silverstar194 a658592
Move to string_view
silverstar194 d09feca
Change factory
silverstar194 4824c30
Various comments
silverstar194 776b32d
Add exclude fix
silverstar194 cecbeba
Remove doc
silverstar194 3bc293e
Moved over some tests
silverstar194 0f39b1c
Renamed
silverstar194 4e9dea0
Renamed
silverstar194 33552d1
Formating
silverstar194 5186ad6
Updates from comments
silverstar194 b6ecdca
Rename extensions
silverstar194 e046dd0
Merge branch 'rewrite-match-lib' into router-filter-matching-lib-cont…
silverstar194 fa594ff
Merge branch 'envoyproxy:main' into rewrite-match-lib
silverstar194 613f15a
from main check_format
silverstar194 225c1f0
Changes per comments
silverstar194 849751e
Formatting clang
silverstar194 e83815b
Changed names
silverstar194 595726f
Fix small bug
silverstar194 f146a0a
Changes for comments
silverstar194 1f7417e
Format
silverstar194 06bcb92
Merge remote-tracking branch 'origin/main' into rewrite-match-lib
silverstar194 b7d8910
Remove optional string
silverstar194 c386a92
Format
silverstar194 3515982
Small nits
silverstar194 686e016
Changed comment
silverstar194 e8d515c
Merge branch 'rewrite-match-lib' into router-filter-matching-lib-cont…
silverstar194 86fd526
Merge in branch
silverstar194 d9e4d91
Revert check_format to main
silverstar194 bbddb4d
Format
silverstar194 522048a
Format
silverstar194 d96998a
Format
silverstar194 b87b213
Format
silverstar194 cb45a60
nits
silverstar194 0d42c56
Change coverage
silverstar194 ea5ad5a
Rename instances left behind
silverstar194 d121c9c
Format
silverstar194 bb70740
Grammer
silverstar194 a800753
Add todo
silverstar194 f1528ba
Add work for proto refactor todo
silverstar194 eb9711b
Merge remote-tracking branch 'origin/main' into rewrite-match-lib-proto
silverstar194 c2b2448
Rename types
silverstar194 b8482e6
Format
silverstar194 d718a3a
Merge branch 'rewrite-match-lib' into router-filter-matching-lib-cont…
silverstar194 5666a9d
Merge branch 'rewrite-match-lib-proto' into router-filter-matching-li…
silverstar194 257702d
Clean up merge issues
silverstar194 6e03162
Change comment
silverstar194 6173aaf
Remove unused method rewritePathTemplatePattern
silverstar194 b56cad5
Format
silverstar194 f36f6b9
Merge remote-tracking branch 'origin/main' into router-filter-matchin…
silverstar194 ce23b02
Merge remote-tracking branch 'origin/main' into router-filter-matchin…
silverstar194 69c7c25
Add link to docs
silverstar194 443cdcf
Add link to docs
silverstar194 a3f450d
Partly moved code
silverstar194 10b3b6a
Roll about some changes
silverstar194 43e02ef
Progress towards renaming
silverstar194 d9e1293
Progress towards renaming
silverstar194 a0ae407
Format
silverstar194 bad506f
Format
silverstar194 1ba7fe7
Format
silverstar194 5da0dbb
Spelling
silverstar194 016b047
Fix tests
silverstar194 cad3d1c
Format and rename
silverstar194 23d11a1
Format and rename
silverstar194 83d9498
Format and rename
silverstar194 3166bd4
Format and rename
silverstar194 06ff4ae
Remove policy classes
silverstar194 7721644
Remove policy classes
silverstar194 9a67cf6
Merge remote-tracking branch 'origin/main' into router-filter-matchin…
silverstar194 149756b
Merge remote-tracking branch 'origin/main' into router-filter-matchin…
silverstar194 09b63b4
Remove old policy classes and address comments
silverstar194 bbf017a
Revert extensions_build_config.bzl
silverstar194 a9c59e4
Change names for small nit
silverstar194 7d1c8d8
Change name
silverstar194 a28f4dd
Format
silverstar194 e90c05f
Format
silverstar194 2abde45
Changed dictionary
silverstar194 c7c0cf3
Added tests
silverstar194 3d14860
Format
silverstar194 7250108
Removed reduced coverage
silverstar194 df35c90
Add fuzzing
silverstar194 97f3666
Tests
silverstar194 485fc23
Merge remote-tracking branch 'origin/main' into pattern-match-rewrite…
silverstar194 34504f2
Tests
silverstar194 aefed6e
Nit grammer
silverstar194 39ed01b
Add validation
silverstar194 4dcf1f5
Remove fuzz
silverstar194 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We should be able to directly use
prefix_rewrite_that has already been initialized, right? This avoids redundant function call to route() and prefix_rewrite().We can even merge this into the if block in line 659. But I think merging will be a bit micro-optimization and keep the separate two checks here helps readability.
Changing to
prefix_rewrite_is good enough IMO.