Pattern match and rewrite fuzzing by silverstar194 · Pull Request #23132 · envoyproxy/envoy

silverstar194 · 2022-09-15T16:02:15Z

Commit Message:
Pattern match and rewrite fuzzing

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]

[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: silverstar195 <seanmaloney@google.com>

…er-filter-matching-lib-control-plane # Conflicts: # envoy/router/BUILD # source/extensions/extensions_build_config.bzl # source/extensions/extensions_metadata.yaml # tools/extensions/extensions_schema.yaml Signed-off-by: silverstar195 <seanmaloney@google.com>

Signed-off-by: silverstar195 <seanmaloney@google.com>

…ite-extention-lib Signed-off-by: silverstar195 <seanmaloney@google.com>

Signed-off-by: silverstar195 <seanmaloney@google.com>

…ter-filter-matching-lib-control-plane Signed-off-by: silverstar195 <seanmaloney@google.com>

Signed-off-by: silverstar195 <seanmaloney@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: silverstar195 <seanmaloney@google.com> # Conflicts: # api/envoy/config/route/v3/route_components.proto

Signed-off-by: silverstar195 <seanmaloney@google.com>

silverstar194 · 2022-09-15T18:46:08Z

/retest

repokitteh-read-only · 2022-09-15T18:46:12Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23132 (comment) was created by @silverstar194.

see: more, trace.

silverstar194 · 2022-09-15T19:13:46Z

/retest

repokitteh-read-only · 2022-09-15T19:13:50Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23132 (comment) was created by @silverstar194.

see: more, trace.

silverstar194 · 2022-09-15T20:02:39Z

/retest

repokitteh-read-only · 2022-09-15T20:02:43Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23132 (comment) was created by @silverstar194.

see: more, trace.

RyanTheOptimist · 2022-09-15T21:05:57Z

/assign @adisuissa

RyanTheOptimist · 2022-09-15T21:06:38Z

@adisuissa AIUI, you've got a lot of experience with Envoy fuzzers. Can you take a look?

adisuissa

LGTM thanks!
One question, did you let the fuzzer run for a while (just to see if there were any unexpected findings)?

/wait-any

Signed-off-by: silverstar195 <seanmaloney@google.com>

silverstar194 · 2022-09-16T13:29:13Z

@adisuissa I run the tests locally several times until they completed.

adisuissa

As discussed offline, let's run the fuzzer for a short while in fuzzing mode, and if no bugs are found we can merge this.

/retest

repokitteh-read-only · 2022-09-16T15:55:18Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23132 (review) was submitted by @adisuissa.

see: more, trace.

RyanTheOptimist · 2022-09-16T20:32:59Z

/wait

silverstar194 · 2022-09-19T14:17:21Z

/retest

repokitteh-read-only · 2022-09-19T14:17:28Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23132 (comment) was created by @silverstar194.

see: more, trace.

silverstar194 · 2022-09-19T15:31:29Z

Ran fuzzing for around an hour no issues.

adisuissa

LGTM, thanks!

silverstar194 added 30 commits July 14, 2022 20:16

Style and lint fixes

f7670a1

Signed-off-by: silverstar195 <seanmaloney@google.com>

Document change

029e9ee

Signed-off-by: silverstar195 <seanmaloney@google.com>

Adding TypedExtensionConfig

e14d4d6

Signed-off-by: silverstar195 <seanmaloney@google.com>

Incremental Change

4846099

Signed-off-by: silverstar195 <seanmaloney@google.com>

Merge branch 'main' into rewrite-extention-lib

1405a3c

Added import

e3cb859

Signed-off-by: silverstar195 <seanmaloney@google.com>

Merge remote-tracking branch 'origin/rewrite-extention-lib' into rewr…

9314a34

…ite-extention-lib Signed-off-by: silverstar195 <seanmaloney@google.com>

Style and formatting

db9aa98

Signed-off-by: silverstar195 <seanmaloney@google.com>

Spelling

03fc99b

Signed-off-by: silverstar195 <seanmaloney@google.com>

Added import

b4a840b

Signed-off-by: silverstar195 <seanmaloney@google.com>

Style

cf26d41

Signed-off-by: silverstar195 <seanmaloney@google.com>

Style

f493c54

Signed-off-by: silverstar195 <seanmaloney@google.com>

Added string words

3543c89

Signed-off-by: silverstar195 <seanmaloney@google.com>

Change extension name

910f0a1

Signed-off-by: silverstar195 <seanmaloney@google.com>

Change import

75a8e66

Signed-off-by: silverstar195 <seanmaloney@google.com>

Changed extension name

be8991e

Signed-off-by: silverstar195 <seanmaloney@google.com>

Added import

c6b511d

Signed-off-by: silverstar195 <seanmaloney@google.com>

Changed title

7c4ec0a

Signed-off-by: silverstar195 <seanmaloney@google.com>

Separate extension into two

5ee9933

Signed-off-by: silverstar195 <seanmaloney@google.com>

Merge remote-tracking branch 'origin/rewrite-extention-duel' into rou…

2466c3d

…ter-filter-matching-lib-control-plane Signed-off-by: silverstar195 <seanmaloney@google.com>

Cleaned up code

75beba0

Signed-off-by: silverstar195 <seanmaloney@google.com>

Proto changes for pattern template

dc8bae1

Signed-off-by: silverstar195 <seanmaloney@google.com>

Proto changes for pattern template

2dadf3d

Signed-off-by: silverstar195 <seanmaloney@google.com>

Proto changes for pattern template

cb86b2c

Signed-off-by: silverstar195 <seanmaloney@google.com>

Merge branch 'main' into pattern-template-extention-proto

ed0b7e9

docs: Cleanup more literals in API docs (envoyproxy#22174)

1990651

Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: silverstar195 <seanmaloney@google.com> # Conflicts: # api/envoy/config/route/v3/route_components.proto

Add space

403349a

Signed-off-by: silverstar195 <seanmaloney@google.com>

Spelling

e7d3877

Signed-off-by: silverstar195 <seanmaloney@google.com>

Small style and grammar changes

37c854a

Signed-off-by: silverstar195 <seanmaloney@google.com>

silverstar194 marked this pull request as ready for review September 15, 2022 18:40

silverstar194 requested a review from alyssawilk as a code owner September 15, 2022 18:40

repokitteh-read-only Bot assigned adisuissa Sep 15, 2022

adisuissa reviewed Sep 15, 2022

View reviewed changes

repokitteh-read-only Bot added the waiting:any label Sep 15, 2022

adisuissa reviewed Sep 15, 2022

View reviewed changes

Comment thread test/extensions/path/uri_template_lib/uri_template_fuzz_test.cc Outdated

Comment thread test/extensions/path/uri_template_lib/uri_template_fuzz_test.cc Outdated

repokitteh-read-only Bot removed waiting:any labels Sep 15, 2022

Nit grammer

aefed6e

Signed-off-by: silverstar195 <seanmaloney@google.com>

silverstar194 requested review from adisuissa and removed request for alyssawilk September 16, 2022 13:29

adisuissa reviewed Sep 16, 2022

View reviewed changes

repokitteh-read-only Bot added the waiting label Sep 16, 2022

silverstar194 requested a review from adisuissa September 19, 2022 15:31

adisuissa approved these changes Sep 19, 2022

View reviewed changes

adisuissa merged commit d79be8c into envoyproxy:main Sep 19, 2022

Conversation

silverstar194 commented Sep 15, 2022

Uh oh!

silverstar194 commented Sep 15, 2022

Uh oh!

repokitteh-read-only Bot commented Sep 15, 2022

Uh oh!

silverstar194 commented Sep 15, 2022

Uh oh!

repokitteh-read-only Bot commented Sep 15, 2022

Uh oh!

silverstar194 commented Sep 15, 2022

Uh oh!

repokitteh-read-only Bot commented Sep 15, 2022

Uh oh!

RyanTheOptimist commented Sep 15, 2022

Uh oh!

RyanTheOptimist commented Sep 15, 2022

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

silverstar194 commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

repokitteh-read-only Bot commented Sep 16, 2022

Uh oh!

RyanTheOptimist commented Sep 16, 2022

Uh oh!

silverstar194 commented Sep 19, 2022

Uh oh!

repokitteh-read-only Bot commented Sep 19, 2022

Uh oh!

silverstar194 commented Sep 19, 2022

Uh oh!

adisuissa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

silverstar194 commented Sep 16, 2022 •

edited

Loading