Thrift: Do not reset downstream for partial response#23117
Merged
zuercher merged 2 commits intoenvoyproxy:mainfrom Sep 16, 2022
Merged
Thrift: Do not reset downstream for partial response#23117zuercher merged 2 commits intoenvoyproxy:mainfrom
zuercher merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
zuercher
reviewed
Sep 15, 2022
| initializeRouter(); | ||
|
|
||
| EXPECT_CALL(callbacks_, resetDownstreamConnection()); | ||
| // EXPECT_CALL(callbacks_, resetDownstreamConnection()); |
Member
There was a problem hiding this comment.
Is there a test that invokes the underflow path?
Contributor
Author
There was a problem hiding this comment.
thanks for catch the leftover. yes there is.
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
zuercher
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuochunghsu kuochunghsu@pinterest.com
Commit Message:
We've seen upstream connection is closed between response start and response end, which closes downstream connection and leads SR drop.
This disconnection is an intentional behavior from the service since thrift doesn't have a RST semantic.
In this diff, we do local reply to downstream instead of resetting it since we haven't sent any byte to downstream.
Risk Level: low
Testing: unit