Skip to content

Update QUICHE from c2576eff3 to 3743c9285#23073

Merged
RyanTheOptimist merged 11 commits intoenvoyproxy:mainfrom
RenjieTang:merge-sep
Sep 17, 2022
Merged

Update QUICHE from c2576eff3 to 3743c9285#23073
RyanTheOptimist merged 11 commits intoenvoyproxy:mainfrom
RenjieTang:merge-sep

Conversation

@RenjieTang
Copy link
Copy Markdown
Contributor

@RenjieTang RenjieTang commented Sep 13, 2022

https://github.com/google/quiche/compare/c2576eff3..3743c9285

$ git log c2576eff3..3743c9285 --date=short --no-merges --format="%ad %al %s"

2022-09-13 renjietang Use NiceMock for MockRandom to fix test failures in Envoy.
2022-09-12 quiche-dev Internal change
2022-09-12 quiche-dev Internal change
2022-09-12 martinduke ConnectionIdGenerator that uses QUIC-LB or HASH_QUIC depending on config.
2022-09-12 birenroy Makes the FLAGS_ prefix implicit in calls to GetQuicFlag().
2022-09-09 wub Internal change
2022-09-09 martinduke Internal change
2022-09-09 vasilvv Migrate QuicGoogleClient to use QuicEventLoop.
2022-09-09 quiche-dev Collapse InformationalResponseInternal class into public InformationalResponse.
2022-09-09 wub Allow caller of QuicFramer::BuildIetfStatelessResetPacket to provide a random bytes generator.
2022-09-09 quiche-dev Internal change
2022-09-09 quiche-dev Pass QUIC client connection ID to ProofSource.
2022-09-08 ramosalex Add bind to interface socket option support to QuicClientDefaultNetworkHelper.
2022-09-08 renjietang Populate stats needed for multi-port.
2022-09-07 diannahu Drop buffered metadata for a stream in ForgetStream().
2022-09-06 martinduke Fix incorrect flag checks in quic_connection_test.
2022-09-06 bnc Move QuicIpAddress and IpAddressFamily to third_party/quiche.
2022-09-06 martinduke Fix broken tests.
2022-09-06 quiche-dev Make binary_http library available to external bazel users.
2022-09-06 bnc Enabling rolled out flags.
2022-09-06 martinduke Extend LoadBalancerEncoder to support ConnectionIdGeneratorInterface.
2022-09-06 bnc Add missing includes.
2022-09-06 martinduke Automated g4 rollback of changelist 471573005.
2022-09-06 vasilvv Remove the use of QuicEpoll in qbone_session_test
2022-09-02 quiche-dev Fix file descriptor leak (on bind() failure) in QUIC client.
2022-09-02 ericorth Simplify higher-level socket interfaces
2022-09-02 quiche-dev Convert quic_bounded_crypto_send_buffer to a QUIC_PROTOCOL_FLAG
2022-09-01 quiche-dev Fix broken bazel build.
2022-09-01 quiche-dev Add absl/cleanup to dependencies for quiche_core.
2022-09-01 fayang Deprecate gfe2_reloadable_flag_quic_fix_bytes_accounting_for_buffered_coalesced_packets.
2022-09-01 martinduke Change LoadBalancerEncoder::Create to return unique_ptr.
2022-09-01 martinduke Update QuicConnection to Use ConnectionIdGeneratorInterface.
2022-09-01 quiche-dev Stop calling memcpy when bytes_to_copy is 0
2022-08-31 vasilvv Split quic_client_lib into quic_client_lib and quic_epoll_client_lib
2022-08-31 wub Internal change
2022-08-30 quiche-dev Open source Binary Http.
2022-08-30 vasilvv Fix and re-enable tests disabled in cl/468791547

Risk Level: Low
Testing: Existing tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

https://github.com/google/quiche/compare/c2576eff3..27bf7b273

$ git log c2576eff3..27bf7b273 --date=short --no-merges --format="%ad %al %s"

2022-09-09 wub Internal change
2022-09-09 martinduke Internal change
2022-09-09 vasilvv Migrate QuicGoogleClient to use QuicEventLoop.
2022-09-09 quiche-dev Collapse InformationalResponseInternal class into public InformationalResponse.
2022-09-09 wub Allow caller of QuicFramer::BuildIetfStatelessResetPacket to provide a random bytes generator.
2022-09-09 quiche-dev Internal change
2022-09-09 quiche-dev Pass QUIC client connection ID to ProofSource.
2022-09-08 ramosalex Add bind to interface socket option support to QuicClientDefaultNetworkHelper.
2022-09-08 renjietang Populate stats needed for multi-port.
2022-09-07 diannahu Drop buffered metadata for a stream in ForgetStream().
2022-09-06 martinduke Fix incorrect flag checks in quic_connection_test.
2022-09-06 bnc Move QuicIpAddress and IpAddressFamily to third_party/quiche.
2022-09-06 martinduke Fix broken tests.
2022-09-06 quiche-dev Make binary_http library available to external bazel users.
2022-09-06 bnc Enabling rolled out flags.
2022-09-06 martinduke Extend LoadBalancerEncoder to support ConnectionIdGeneratorInterface.
2022-09-06 bnc Add missing includes.
2022-09-06 martinduke Automated g4 rollback of changelist 471573005.
2022-09-06 vasilvv Remove the use of QuicEpoll in qbone_session_test
2022-09-02 quiche-dev Fix file descriptor leak (on `bind()` failure) in QUIC client.
2022-09-02 ericorth Simplify higher-level socket interfaces
2022-09-02 quiche-dev Convert quic_bounded_crypto_send_buffer to a QUIC_PROTOCOL_FLAG
2022-09-01 quiche-dev Fix broken bazel build.
2022-09-01 quiche-dev Add absl/cleanup to dependencies for quiche_core.
2022-09-01 fayang Deprecate gfe2_reloadable_flag_quic_fix_bytes_accounting_for_buffered_coalesced_packets.
2022-09-01 martinduke Change LoadBalancerEncoder::Create to return unique_ptr.
2022-09-01 martinduke Update QuicConnection to Use ConnectionIdGeneratorInterface.
2022-09-01 quiche-dev Stop calling memcpy when `bytes_to_copy` is 0
2022-08-31 vasilvv Split quic_client_lib into quic_client_lib and quic_epoll_client_lib
2022-08-31 wub Internal change
2022-08-30 quiche-dev Open source Binary Http.
2022-08-30 vasilvv Fix and re-enable tests disabled in cl/468791547

Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Renjie Tang <renjietang@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #23073 was opened by RenjieTang.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Sep 13, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #23073 was opened by RenjieTang.

see: more, trace.

https://github.com/google/quiche/compare/27bf7b273..3743c9285

$ git log 27bf7b273..3743c9285 --date=short --no-merges --format="%ad %al %s"

2022-09-13 renjietang Use NiceMock for MockRandom to fix test failures in Envoy.
2022-09-12 quiche-dev Internal change
2022-09-12 quiche-dev Internal change
2022-09-12 martinduke ConnectionIdGenerator that uses QUIC-LB or HASH_QUIC depending on config.
2022-09-12 birenroy Makes the `FLAGS_` prefix implicit in calls to `GetQuicFlag()`.

Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Renjie Tang <renjietang@google.com>
@RenjieTang RenjieTang changed the title Merge sep Update QUICHE from c2576eff3 to 3743c9285 Sep 13, 2022
Signed-off-by: Renjie Tang <renjietang@google.com>
@RenjieTang RenjieTang marked this pull request as ready for review September 13, 2022 22:03
@RenjieTang
Copy link
Copy Markdown
Contributor Author

/assign @RyanTheOptimist

Copy link
Copy Markdown
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This looks like a heck of a saga. Thanks for doing this!

Comment thread source/common/quic/envoy_deterministic_connection_id_generator.cc
@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 13, 2022
Signed-off-by: Renjie Tang <renjietang@google.com>
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Sep 13, 2022
@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 13, 2022
@RyanTheOptimist RyanTheOptimist enabled auto-merge (squash) September 13, 2022 22:21
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

But looks like you have some CI errors

@alyssawilk
Copy link
Copy Markdown
Contributor

Almost there!
I think compile time options build need #ifdef ENVOY_ENABLE_QUIC around QUIC code to make sure Envoy and core tests still pass with QUIC built out.

Signed-off-by: Renjie Tang <renjietang@google.com>
auto-merge was automatically disabled September 14, 2022 17:19

Head branch was pushed to by a user without write access

@RenjieTang
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23073 (comment) was created by @RenjieTang.

see: more, trace.

@alyssawilk
Copy link
Copy Markdown
Contributor

Code coverage for source/common/quic is lower than limit of 91.8 (91.7) :-(

I'd say we can bump coverage down, and add a TODO for someone on our team to add unit tests and bump it back up.
I could take that on, as Renjie has effectively done my merge rotation as well as his own.

@alyssawilk
Copy link
Copy Markdown
Contributor

#23128 for tracking

@RyanTheOptimist
Copy link
Copy Markdown
Contributor

@RenjieTang it looks like DCO is broken. Mind fixing and re-pushing?

Signed-off-by: Renjie Tang <renjietang@google.com>
@RyanTheOptimist RyanTheOptimist enabled auto-merge (squash) September 16, 2022 21:59
@RyanTheOptimist RyanTheOptimist merged commit 0d05963 into envoyproxy:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants