Improve the example for the Kafka Broker filter#23044
Conversation
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
|
@nguyenptk @phlax Sorry it took so long (back from holidays). There was a small mis-config in Confluent Docker image that made the traffic reach the "internal" Kafka server socket, making the connections work (surprising) but the follow-up traffic actually went |
|
/review @phlax @nguyenptk |
|
@nguyenptk cannot be assigned as a reviewer to this issue. |
|
(just realized there's a verify check I need to amend a little) |
| kafka.kafka_broker.response.find_coordinator_response: 1 | ||
| kafka.kafka_broker.response.metadata_response: 4 | ||
| $ curl -s "http://localhost:8001/stats?filter=kafka.kafka_broker" | grep -v ": 0" | grep "_request:" | ||
| kafka.kafka_broker.request.api_versions_request: 9 |
There was a problem hiding this comment.
We also need to update the verify.sh to fix the pipeline's error here
> [kafka] Check admin kafka_broker stats
ERROR: curl (http://localhost:11101/stats?filter=kafka.kafka_broker.request.api_versions_request)
EXPECTED: kafka.kafka_broker.request.api_versions_request: 4
RECEIVED:
kafka.kafka_broker.request.api_versions_request: 9
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
/review @phlax |
adamkotwasinski
requested review from
nguyenptk
and removed request for
phlax
|
/review @phlax |
repokitteh-read-only
Bot
requested review from
phlax
and removed request for
nguyenptk
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, thanks @adamkotwasinski for cleaning this up
3 participants
Commit Message: Improve the example for the Kafka Broker filter
Additional Description: Makes the client traffic actually go through Envoy
Risk Level: Low
Testing: README.md guideline
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A