compression: support choosing compressor first when the q-values are same#23005
Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom Sep 15, 2022
Merged
compression: support choosing compressor first when the q-values are same#23005mattklein123 merged 5 commits intoenvoyproxy:mainfrom
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
Conversation
added 2 commits
September 2, 2022 15:26
Signed-off-by: giantcroc <changran.wang@intel.com>
Signed-off-by: giantcroc <changran.wang@intel.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
soulxu
reviewed
Sep 7, 2022
Author
|
/retest |
|
Retrying Azure Pipelines: |
soulxu
reviewed
Sep 9, 2022
soulxu
reviewed
Sep 9, 2022
Signed-off-by: giantcroc <changran.wang@intel.com>
Signed-off-by: giantcroc <changran.wang@intel.com>
Member
|
LGTM, thanks! @mattklein123 for maintainer review |
Member
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
requested changes
Sep 14, 2022
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small comment, thanks.
/wait
Signed-off-by: giantcroc <changran.wang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: giantcroc changran.wang@intel.com
Commit Message:
As #21068, we need to add an option to let user not order to choose specific compressor when the q-values in
Accept-Encodingare same.Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #21068
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]