Skip to content

perf: various fixes to reduce allocations#230

Merged
mattklein123 merged 1 commit intomasterfrom
more_perf
Nov 17, 2016
Merged

perf: various fixes to reduce allocations#230
mattklein123 merged 1 commit intomasterfrom
more_perf

Conversation

@mattklein123
Copy link
Member

@mattklein123 mattklein123 commented Nov 17, 2016

  1. Use vector in thread local vs map
  2. Remove extra allocation for each request from codec client
  3. remove extra allocation for each request from http/1.1 conn pool
  4. Use vector for stream reset callbacks

@mattklein123
perf: various fixes to reduce allocations
e3de1ca 
1) Use vector in thread local vs map
2) Remove extra allocation for each request from codec client
3) remove extra allocation for each request from http/1.1 conn pool
4) Use vector for stream reset callbacks
@mattklein123
Copy link
Member Author

mattklein123 commented Nov 17, 2016

@lyft/network-team

@mattklein123 mattklein123 merged commit 67ca72c into master Nov 17, 2016
@mattklein123 mattklein123 deleted the more_perf branch November 17, 2016 16:05
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
@lizan
s/protobuf_bzl/com_google_protobuf/ (envoyproxy#230)
e9f02b2
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this pull request Jul 20, 2020
Merge pull request envoyproxy#230 from istio/release-1.4.11-patch
54e9758 
Release 1.4.11 patch
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021
@majinghe
Merge pull request envoyproxy#230 from WisWang/zh-trans-207
5f9b192 
zh-translation: /start/sandboxes/cors.rst
mattklein123 pushed a commit that referenced this pull request Apr 15, 2021
@adisuissa @tonya11en
http: Fixing empty metadata map handling (#230) (#248)
4105bfb 
Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123 pushed a commit that referenced this pull request Apr 15, 2021
@adisuissa @tonya11en
http: Fixing empty metadata map handling (#230) (#249)
a00f9d4 
Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123 pushed a commit that referenced this pull request Apr 15, 2021
@tonya11en
http: Fixing empty metadata map handling (#230) #250
50f292d 
Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123 pushed a commit that referenced this pull request Apr 15, 2021
@adisuissa @tonya11en
http: Fixing empty metadata map handling (#230) (#253)
e7c1142 
Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <tony@allen.gg>
esmet pushed a commit to gravitee-io/envoy that referenced this pull request Apr 15, 2021
@adisuissa @tonya11en @esmet
http: Fixing empty metadata map handling (envoyproxy#230) (envoyproxy…
c94cace 
…#249)

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
howardjohn pushed a commit to howardjohn/envoy that referenced this pull request Apr 16, 2021
@bianpengyuan @tonya11en
@Shikugawa @cpakulski
Cherry-pick fix for greenpig (envoyproxy#312)
3887a0c 
* http: Fixing empty metadata map handling (envoyproxy#230) envoyproxy#250

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <tony@allen.gg>

* grpc: fix grpc-timeout integer overflow (envoyproxy#255)

Fixes CVE-2021-28682, a remotely exploitable integer overflow.

Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Tony Allen <tony@allen.gg>

* ssl: fix crash when peer sends an SSL Alert with an unknown code (envoyproxy#259)

Fixes CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code)

Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Tony Allen <tony@allen.gg>

Co-authored-by: Tony Allen <tony@allen.gg>
Co-authored-by: Rei Shimizu <Shikugawa@gmail.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
douglas-reid referenced this pull request in douglas-reid/envoy Apr 19, 2021
@adisuissa @douglas-reid
http: Fixing empty metadata map handling (#230) (#253)
c7783e0 
Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <tony@allen.gg>

Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
tbarrella referenced this pull request in tbarrella/envoy May 3, 2021
@bianpengyuan @tonya11en
@Shikugawa @cpakulski
Cherry-pick GREENPIG for 1.9 (#313)
f859253 
* backport to 1.17: http: Fixing empty metadata map handling (#230) (#252)

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <tony@allen.gg>

* ssl: fix crash when peer sends an SSL Alert with an un… (#262)

Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code)

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Tony Allen <tony@allen.gg>

* grpc: fix grpc-timeout integer overflow (#254)

Fixes CVE-2021-28682, a remotely exploitable integer overflow.

Signed-off-by: Asra Ali <asraa@google.com>
Co-authored-by: Tony Allen <tony@allen.gg>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Tony Allen <tony@allen.gg>

Co-authored-by: Tony Allen <tony@allen.gg>
Co-authored-by: Rei Shimizu <Shikugawa@gmail.com>
Co-authored-by: Christoph Pakulski <christoph@tetrate.io>
gokulnair pushed a commit to gokulnair/envoy that referenced this pull request May 6, 2021
@adisuissa
http: Fixing empty metadata map handling (envoyproxy#230) (envoyproxy…
aeeddae 
…#253)

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Gokul Nair <gnair@twitter.com>
yanavlasov pushed a commit to yanavlasov/envoy that referenced this pull request Aug 6, 2021
@adisuissa @yanavlasov
backport to 1.12: http: Fixing empty metadata map handling (envoyprox…
40749c7 
…y#230)

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
LukeShu pushed a commit to gravitee-io/envoy that referenced this pull request Aug 10, 2021
@adisuissa @tonya11en @LukeShu
http: Fixing empty metadata map handling (envoyproxy#230) (envoyproxy…
7db9674 
…#249)

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
(cherry picked from commit a00f9d4)
LukeShu pushed a commit to gravitee-io/envoy that referenced this pull request Aug 10, 2021
@adisuissa @tonya11en @LukeShu
http: Fixing empty metadata map handling (envoyproxy#230) (envoyproxy…
4d1917f 
…#249)

Commit Message: Fixing a crash when the decoder receives an empty metadata map.

Additional Description:
Upon receiving an empty metadata map and trying to decode it an assertion is triggered in debug mode, and a seg-fault occurs in release mode.
The proposed fix ignores the empty metadata maps and updates a stats if one is received.

Risk Level: Medium for Envoy's running with Metadata support.
Testing: Added integration tests.
Docs Changes: Added a codec stats counter description.
Release Notes: Added bug fix description.
Platform Specific Features: N/A.
Fixes a fuzz bug: 25303

Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Co-authored-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
(cherry picked from commit a00f9d4)
jpsim pushed a commit that referenced this pull request Nov 28, 2022
@goaway @jpsim
library: migrate public/feature layer of iOS library to Swift
073484b 
Co-authored-by: Keith Smiley keithbsmiley@gmail.com
Signed-off-by: Mike Schore mike.schore@gmail.com

Description: We've decided to implement our public and platform-specific library layer primarily in Swift on iOS. Migrating to this has some repercussions for the build and for the time-being will require custom Bazel rules to compose the distributable static framework. This PR migrates the code to swift and introduces the build rules required. Note: this PR breaks objective-c. This is known and an issue has been filed #230.
Risk Level: Medium - moves pieces of the library to swift, and introduces new build rules.
Testing: CI

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
@goaway @jpsim
library: migrate public/feature layer of iOS library to Swift
e13d4e9 
Co-authored-by: Keith Smiley keithbsmiley@gmail.com
Signed-off-by: Mike Schore mike.schore@gmail.com

Description: We've decided to implement our public and platform-specific library layer primarily in Swift on iOS. Migrating to this has some repercussions for the build and for the time-being will require custom Bazel rules to compose the distributable static framework. This PR migrates the code to swift and introduces the build rules required. Note: this PR breaks objective-c. This is known and an issue has been filed #230.
Risk Level: Medium - moves pieces of the library to swift, and introduces new build rules.
Testing: CI

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
soulxu pushed a commit to soulxu/envoy that referenced this pull request Feb 27, 2024
@daixiang0
ci: support static build (envoyproxy#230)
5a1fa09 
Signed-off-by: Loong <loong.dai@intel.com>
arminabf pushed a commit to arminabf/envoy that referenced this pull request Jun 5, 2024
@jcchavezs
chore: upgrades to Coraza 3.0.4. (envoyproxy#230)
6c194a9
mathetake added a commit that referenced this pull request Mar 3, 2026
@mathetake
ci: separates out style checks from tests (#230)
4b19831 
**Commit Message**:

This moves the style checks from the test jobs,
so that we can set the paths-ignores on these
test targets while always running style check
regardless of the changed files.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RomanDzhabarov RomanDzhabarov RomanDzhabarov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattklein123 @RomanDzhabarov