gcp_authn: Override any existing value in the request header that includes authn: Bearer id token#22934
Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom Sep 19, 2022
Merged
Conversation
…d token Signed-off-by: Tianyu Xia <tyxia@google.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/assign @yanavlasov Could you please take a look? Thanks! |
tyxia
changed the title
Contributor
|
/wait |
Signed-off-by: Tianyu Xia <tyxia@google.com>
Signed-off-by: Tianyu Xia <tyxia@google.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
Author
|
@yanavlasov The test coverage is added and PTAL. Thanks! |
yanavlasov
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: If an incoming request includes an existing Authorization token, we should override instead of appending to the existing value.
Fix: Use
setCopyinstead ofaddCopyfor the override behavior.Signed-off-by: Tianyu Xia tyxia@google.com