Skip to content

wasm: set upper limit for maximum Wasm memory size when using V8.#22117

Merged
lizan merged 3 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-memory_limit
Jul 13, 2022
Merged

wasm: set upper limit for maximum Wasm memory size when using V8.#22117
lizan merged 3 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-memory_limit

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #22117 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Jul 11, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #22117 was opened by PiotrSikora.

see: more, trace.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora marked this pull request as ready for review July 12, 2022 01:53
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

@lizan PTAL. This blocks Proxy-Wasm C++ Host updates, since V8 flags are out-of-sync between Proxy-Wasm C++ Host and wee8_compile. I'm going to move wee8_compile to Proxy-Wasm C++ Host later, but I want to unblock it first.

Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@wrowe can you PTAL at the dependencies?
@lizan for a non-google review

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 13, 2022
@lizan lizan merged commit 3efb46f into envoyproxy:main Jul 13, 2022
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 15, 2022
…voyproxy#22117)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Nov 15, 2022
…voyproxy#22117)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Nov 16, 2022
…2117)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Nov 18, 2022
…2117)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants