Big edf entry deadline when slow start enabled.#22054
Big edf entry deadline when slow start enabled.#22054pyrl247 wants to merge 1 commit intoenvoyproxy:mainfrom pyrl247:main
Conversation
it will cause big edf entry deadline, and the entry will not be selected in a long time. Signed-off-by: Guang Yang <pyrl247@gmail.com>
|
#19526 have the same problem,min_weight_percent could fix the problem,but I think change it to 1 second could be more appropriate. |
|
/assign @mattklein123 Appears you initially had reviewed #13176 when this was introduced |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for working on this. I don't fully understand this change so requesting some more information. Thank you!
/wait
|
|
||
| ASSERT(aggression_ > 0.0); | ||
| auto time_factor = static_cast<double>(std::max(std::chrono::milliseconds(1).count(), | ||
| auto time_factor = static_cast<double>(std::max(std::chrono::milliseconds(1000).count(), |
There was a problem hiding this comment.
Sorry I don't understand the implications of this change. Can you:
- Add more comments.
- Add some kind of test.
- Add a release note.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
3 participants
it will cause big edf entry deadline, and the entry will not be selected in a
long time.
Signed-off-by: Guang Yang pyrl247@gmail.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]