network: allow Apple platforms to force IPv6 sockets#21913
Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom Jun 28, 2022
jpsim:network-allow-non-android-platforms-to-force-ipv6-sockets
Merged
network: allow Apple platforms to force IPv6 sockets#21913mattklein123 merged 5 commits intoenvoyproxy:mainfrom jpsim:network-allow-non-android-platforms-to-force-ipv6-sockets
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
jpsim:network-allow-non-android-platforms-to-force-ipv6-sockets
Conversation
We suspect that under some conditions, non-Android platforms (i.e. iOS) also would benefit from forcibly using IPv6 sockets, so to validate this this change adds a new runtime feature generalizing the one added for Android. Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
|
Marked as draft as I test in Envoy Mobile. |
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
And only apply `forceV6()` on Android or Apple platforms. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
commented
Jun 28, 2022
| sin6.sin6_addr.s6_addr32[2] = htonl(0xffff); | ||
| sin6.sin6_addr.s6_addr32[3] = sin4.sin_addr.s_addr; | ||
| #elif defined(__APPLE__) | ||
| sin6.sin6_addr.__u6_addr.__u6_addr32[2] = htonl(0xffff); |
Contributor
Author
There was a problem hiding this comment.
Linux headers on the left, Darwin on the right.
Contributor
Author
|
/assign @mattklein123 @Augustyniak |
jpsim
changed the title
Augustyniak
approved these changes
Jun 28, 2022
jpsim
deleted the
network-allow-non-android-platforms-to-force-ipv6-sockets
branch
jpsim
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 28, 2022
Mirroring what was done for Android in #2379 and leveraging the recent changes in Envoy in envoyproxy/envoy#21913. Risk Level: Moderate. Testing: Unit tests, integration tests & being exercised in the experimental app. Tested with the experimental app in the iOS Simulator and on an iPhone 13 Pro, verified that an IPv4 address gets mapped to a valid IPv6 address. Docs Changes: Added. Release Notes: Added. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
Mirroring what was done for Android in envoyproxy/envoy-mobile#2379 and leveraging the recent changes in Envoy in #21913. Risk Level: Moderate. Testing: Unit tests, integration tests & being exercised in the experimental app. Tested with the experimental app in the iOS Simulator and on an iPhone 13 Pro, verified that an IPv4 address gets mapped to a valid IPv6 address. Docs Changes: Added. Release Notes: Added. Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We suspect that under some conditions, non-Android platforms (i.e. iOS) also would benefit from forcibly using IPv6 sockets, so to validate this this change adds a new runtime feature generalizing the one added for Android.
Risk Level: Low, runtime guard defaults to false.
Testing: Tested on an iPhone 13 Pro via Envoy Mobile, confirmed that an IPv4 address was being mapped to an IPv6 one.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: Not platform specific, but intended to be used on Apple platforms.
Runtime guard:
envoy.reloadable_features.always_use_v6(default false)