Skip to content

build: Update WAMR to get performance improvement#21616

Closed
leyao-daily wants to merge 3 commits intoenvoyproxy:mainfrom
leyao-daily:main
Closed

build: Update WAMR to get performance improvement#21616
leyao-daily wants to merge 3 commits intoenvoyproxy:mainfrom
leyao-daily:main

Conversation

@leyao-daily
Copy link
Copy Markdown
Member

Signed-off-by: Le Yao le.yao@intel.com

Commit Message: Update WAMR to get performance improvement
Additional Description: WAMR has a potential performance improvement based on the newer llvm/compiler-rt
Fixes #19834
Risk Level: Low
Testing: WIP
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Jun 8, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #21616 was opened by leyao-daily.

see: more, trace.

keith
keith previously approved these changes Jun 8, 2022
@leyao-daily
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21616 (comment) was created by @leyao-daily.

see: more, trace.

@moderation
Copy link
Copy Markdown
Contributor

Dependency update looks OK but CI error look real

@leyao-daily
Copy link
Copy Markdown
Member Author

Dependency update looks OK but CI error look real

Yes. The fix is WIP. Thanks.

@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Jun 9, 2022

/retest
to validate that this isn't transitory. Merging main again may be required.

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21616 (comment) was created by @wrowe.

see: more, trace.

@leyao-daily
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21616 (comment) was created by @leyao-daily.

see: more, trace.

@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Jun 13, 2022

/retest
to validate that compile_time_options error isn't transitory

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21616 (comment) was created by @wrowe.

see: more, trace.

@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Jun 13, 2022

/lgtm deps

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 13, 2022
@wrowe
Copy link
Copy Markdown
Contributor

wrowe commented Jun 13, 2022

The main branch is now stable, please merge main @leyao-daily and we'll see where this stands.

/wait

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Jun 14, 2022
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #21616 was synchronize by leyao-daily.

see: more, trace.

@leyao-daily
Copy link
Copy Markdown
Member Author

Sorry to cause annoying review request.

@mattklein123
Copy link
Copy Markdown
Member

CI looks broken to me. PTAL.

/wait

@leyao-daily
Copy link
Copy Markdown
Member Author

Hi, I have check the CI log and found that the errors reduces based on current latest PR compared with the last time main branch.

@leyao-daily
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21616 (comment) was created by @leyao-daily.

see: more, trace.

Le Yao added 2 commits July 13, 2022 02:18
Signed-off-by: Le Yao <le.yao@intel.com>
Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21616 (comment) was created by @leyao-daily.

see: more, trace.

Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily leyao-daily force-pushed the main branch 2 times, most recently from 039a3ba to 14bea69 Compare July 13, 2022 07:12
@leyao-daily
Copy link
Copy Markdown
Member Author

merged with PR #22157, close now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api deps Approval required for changes to Envoy's external dependencies waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer release available org_llvm_releases_compiler_rt: llvmorg-13.0.1 (current: llvmorg-12.0.1)

5 participants