Skip to content

Use absl::Notification when it makes sense#21446

Closed
rgs1 wants to merge 1 commit intoenvoyproxy:mainfrom
rgs1:use-absl-notification
Closed

Use absl::Notification when it makes sense#21446
rgs1 wants to merge 1 commit intoenvoyproxy:mainfrom
rgs1:use-absl-notification

Conversation

@rgs1
Copy link
Copy Markdown
Member

@rgs1 rgs1 commented May 25, 2022

I had to run some code in the main thread for a test recently
and the first example I bumped into wasn't using absl::Notification,
so let's port them over.

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

I had to run some code in the main thread for a test recently
and the first example I bumped into wasn't using absl::Notification,
so let's port them over.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@rgs1
Copy link
Copy Markdown
Member Author

rgs1 commented May 25, 2022

cc: @JuniorHsu

@rgs1
Copy link
Copy Markdown
Member Author

rgs1 commented May 25, 2022

This is a follow-up to #16946.

cc: @antoniovicente

@rgs1
Copy link
Copy Markdown
Member Author

rgs1 commented May 25, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21446 (comment) was created by @rgs1.

see: more, trace.

@KBaichoo
Copy link
Copy Markdown
Contributor

CI failures seem legit:
//test/common/event:dispatcher_impl_test FAILED TO BUILD

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 26, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 3, 2022

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants