Conversation
2 racing callers can leave 1 caller thinking things are initialized while the other caller is still initializing. This change uses absl::call_once to fix that race. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
jmarantz
reviewed
May 2, 2022
Member
Author
|
@jmarantz thanks for the review and great callout! Updated. |
jmarantz
reviewed
May 2, 2022
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
lgtm with one minor nit :)
jmarantz
reviewed
May 2, 2022
jmarantz
reviewed
May 2, 2022
jmarantz
reviewed
May 3, 2022
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
OK updated thanks for the reviews. |
jmarantz
approved these changes
May 3, 2022
Contributor
|
thanks! |
mattklein123
added a commit
that referenced
this pull request
May 3, 2022
2 racing callers can leave 1 caller thinking things are initialized while the other caller is still initializing. This change uses a mutex to fix that race. Risk Level: Low Testing: Existing tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Matt Klein <mklein@lyft.com>
jpsim
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
May 3, 2022
https://github.com/envoyproxy/envoy/compare/em-cherry This pulls in envoyproxy/envoy#21120 on top of the version of Envoy we're currently using. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
May 3, 2022
https://github.com/envoyproxy/envoy/compare/em-cherry This pulls in envoyproxy/envoy#21120 on top of the version of Envoy we're currently using. Signed-off-by: JP Simard <jp@jpsim.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
2 racing callers can leave 1 caller thinking things are initialized while the other caller is still initializing. This change uses a mutex to fix that race. Risk Level: Low Testing: Existing tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Matt Klein <mklein@lyft.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
https://github.com/envoyproxy/envoy/compare/em-cherry This pulls in #21120 on top of the version of Envoy we're currently using. Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 racing callers can leave 1 caller thinking things are
initialized while the other caller is still initializing.
This change uses a mutex to fix that race.
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A