cluster manager: add optional host predicate to drainConnections()#21074
Merged
mattklein123 merged 4 commits intomainfrom Apr 29, 2022
Merged
cluster manager: add optional host predicate to drainConnections()#21074mattklein123 merged 4 commits intomainfrom
mattklein123 merged 4 commits intomainfrom
Conversation
This will allow EM to selectively drain connections based on hostname(), for example. Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
previously approved these changes
Apr 28, 2022
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
code LGTM but I'd like a bit more testing, either here or in a follow up.
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
I'm still trying to figure out a unit test but it's not so easy. I might merge this and then do another PR but I will see how it goes. |
Signed-off-by: Matt Klein <mklein@lyft.com>
RyanTheOptimist
approved these changes
Apr 28, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…nvoyproxy#21074) This will allow EM to selectively drain connections based on hostname(), for example. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow EM to selectively drain connections based on hostname(),
for example.
Risk Level: Low
Testing: New integration test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A