Skip to content

Fixed status check #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nmnellis wants to merge 2 commits into from
Closed

Fixed status check #2032

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780ecf4
Fixed status check
Nov 9, 2017
442350c
fixed lower bound http status code as well
Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/common/http/filter/lua/lua_filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ int StreamHandleWrapper::luaRespond(lua_State* state) {
uint64_t status;
if (headers->Status() == nullptr ||
!StringUtil::atoul(headers->Status()->value().c_str(), status) || status < 200 ||
status >= 500) {
status >= 600) {

@htuch htuch Nov 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. What about the status < 200 clause and claim in error that the range 100-599?

luaL_error(state, ":status must be between 100-599");
}

Expand Down