bazel: Patch m1 support for v8#20216
Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom Mar 10, 2022
Merged
Conversation
I've submitted this upstream as well, but this unblocks us temporarily. Fixes envoyproxy#19916 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
PiotrSikora
approved these changes
Mar 4, 2022
Contributor
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Thanks! Did you verify that Wasm tests pass with this build?
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
Member
Author
|
WASM builds actually still fail for me, but this is one step closer. I'll have to debug the other issues another time |
wrowe
approved these changes
Mar 10, 2022
Contributor
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
Patch is fine, push this through to further refine wasm build troubleshooting
Contributor
|
It doesn't appear we are unique in fighting this; see slack for bazel; |
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Submitted this upstream Partially fixes: envoyproxy#19916 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Nov 15, 2022
Submitted this upstream Partially fixes: envoyproxy#19916 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Nov 18, 2022
Submitted this upstream Partially fixes: #19916 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've submitted this upstream as well, but this unblocks us temporarily.
Fixes #19916
Signed-off-by: Keith Smiley keithbsmiley@gmail.com