config: track message ancestors for unknown fields#20055
Merged
mattklein123 merged 15 commits intoenvoyproxy:mainfrom Mar 10, 2022
Merged
config: track message ancestors for unknown fields#20055mattklein123 merged 15 commits intoenvoyproxy:mainfrom
mattklein123 merged 15 commits intoenvoyproxy:mainfrom
Conversation
timonwong
force-pushed
the
track-msg-path
branch
2 times, most recently
from
6a0cce8 to
2a04beb
Compare
timonwong
changed the title
timonwong
force-pushed
the
track-msg-path
branch
from
2a04beb to
91be573
Compare
timonwong
changed the title
timonwong
force-pushed
the
track-msg-path
branch
24 times, most recently
from
edd5dca to
35c8170
Compare
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
mattklein123
requested changes
Mar 8, 2022
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, this is a great improvement, thanks. Just some small comments. Thank you.
/wait
|
|
||
| if (inner_message != nullptr) { | ||
| traverseMessageWorker(visitor, *inner_message, true, recurse_into_any); | ||
| ScopedMessageParents scoped_parents(parents, message); |
Member
There was a problem hiding this comment.
I'm not 100% positive, but I think you want *inner_message here? Since otherwise I think this will show up as an Any vs. the resolved type? Or you could push both the Any and the resolved type. I'm not sure. Either way, can you add a test that uses recurse_into_any and an example that would do such recursion and verify this looks correct?
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
Contributor
Author
|
/wait |
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
Contributor
Author
|
/wait |
1 similar comment
Contributor
Author
|
/wait |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
JuniorHsu
pushed a commit
to JuniorHsu/envoy
that referenced
this pull request
Mar 17, 2022
Signed-off-by: Tianpeng Wang <tpwang@alauda.io> Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tianpeng Wang tpwang@alauda.io
Commit Message: config: track message ancestors for unknown fields
Additional Description:
Risk Level: Low
Testing: unit test
Docs Changes: N/A
Release Notes: Required
Platform Specific Features: N/A