matchers: implement interval tree for sublinear port range matching#19912
matchers: implement interval tree for sublinear port range matching#19912kyessenov wants to merge 8 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
repokitteh-read-only
bot
removed
the
deps
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Kuat Yessenov <kuat@google.com>
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Very cool stuff. A high level request about code comments before I review in depth. Also, please check the coverage report for this new code, I think you should be able to hit 100% coverage for all error branches. Thank you!
/wait
| namespace Network { | ||
| namespace IntervalTree { | ||
|
|
||
| template <class Data, class N> class IntervalTree { |
There was a problem hiding this comment.
It's very difficult/impossible to read this kind of code and understand what is going on as a new reader. Can you please add a large block comment at the top that describes what this does, provides a high level implementation overview, etc.? Also in general I would over comment the code below if possible.
Also in general this kind of code scares me a bit so you might consider writing a small fuzz test for it to help look for corner cases.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
3 participants
Commit Message: Data structure for efficient lookup of intervals containing a port in the unified matcher framework.
The data structure is a balanced tree of pivots so that:
To ensure balance, the pivots are chosen as medians in the sorted list of all start and end points.
Risk Level: low
Testing: unit, integration
Docs Changes: none (need #20277 )
Release Notes: none