Merged
Conversation
phlax
requested changes
Feb 7, 2022
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
@daixiang0 could you remove it from the Dockerfile also please
Member
Author
|
Please review again. |
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Feb 7, 2022
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Loong <loong.dai@intel.com>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Signed-off-by: Loong <loong.dai@intel.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Loong loong.dai@intel.com
Part of #19781
Commit Message: do not build for alpine anymore.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]