Skip to content

test: more logs deflaking #19779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 1 commit into from
Feb 2, 2022
Merged

test: more logs deflaking #19779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/integration/http_integration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,11 @@ void HttpIntegrationTest::checkSimpleRequestSuccess(uint64_t expected_request_si
void HttpIntegrationTest::testRouterRequestAndResponseWithBody(
uint64_t request_size, uint64_t response_size, bool big_header, bool set_content_length_header,
ConnectionCreationFunction* create_connection, std::chrono::milliseconds timeout) {
#if defined(ENVOY_CONFIG_COVERAGE)
// https://github.com/envoyproxy/envoy/issues/19595
ENVOY_LOG_MISC(warn, "manually lowering logs to error");
LogLevelSetter save_levels(spdlog::level::err);
#endif
initialize();
codec_client_ = makeHttpConnection(
create_connection ? ((*create_connection)()) : makeClientConnection((lookupPort("http"))));
Expand Down
6 changes: 0 additions & 6 deletions test/integration/multiplexed_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,13 @@ TEST_P(MultiplexedIntegrationTest, RouterRequestAndResponseWithGiantBodyNoBuffer
}

TEST_P(MultiplexedIntegrationTest, FlowControlOnAndGiantBody) {
// https://github.com/envoyproxy/envoy/issues/19595
ENVOY_LOG_MISC(warn, "manually lowering logs to error");
LogLevelSetter save_levels(spdlog::level::err);
config_helper_.addConfigModifier(ConfigHelper::adjustUpstreamTimeoutForTsan);
config_helper_.setBufferLimits(1024, 1024); // Set buffer limits upstream and downstream.
testRouterRequestAndResponseWithBody(10 * 1024 * 1024, 10 * 1024 * 1024, false, false, nullptr,
TSAN_TIMEOUT_FACTOR * TestUtility::DefaultTimeout);
}

TEST_P(MultiplexedIntegrationTest, LargeFlowControlOnAndGiantBody) {
// https://github.com/envoyproxy/envoy/issues/19595
ENVOY_LOG_MISC(warn, "manually lowering logs to error");
LogLevelSetter save_levels(spdlog::level::err);
config_helper_.addConfigModifier(ConfigHelper::adjustUpstreamTimeoutForTsan);
config_helper_.setBufferLimits(128 * 1024,
128 * 1024); // Set buffer limits upstream and downstream.
Expand Down