Merged
Conversation
See envoyproxy#19535 (comment) This allows using othe compiler toolchains that are not literally in /usr/include but are still present. I don't think this should impact standard clang builds at all. Signed-off-by: John Howard <howardjohn@google.com>
lizan
approved these changes
Feb 3, 2022
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
See envoyproxy#19535 (comment) This allows using othe compiler toolchains that are not literally in /usr/include but are still present. I don't think this should impact standard clang builds at all. Signed-off-by: John Howard <howardjohn@google.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
#19535 (comment)
This allows using othe compiler toolchains that are not literally in
/usr/include but are still present. I don't think this should impact
standard clang builds at all.
Signed-off-by: John Howard howardjohn@google.com
Commit Message: tcp_stats: use relative import
Additional Description:
See
#19535 (comment)
This allows using othe compiler toolchains that are not literally in
/usr/include but are still present. I don't think this should impact
standard clang builds at all.
Risk Level: None
Testing: existing tests ensure it builds still
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]