file: truncating files which are not opened with append#19745
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Feb 3, 2022
Merged
file: truncating files which are not opened with append#19745alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
previously approved these changes
Feb 2, 2022
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with minor potential comment change.
envoy/filesystem/filesystem.h
Outdated
| enum Operation { | ||
| // Open a file for reading. | ||
| Read, | ||
| // Open a file for writing. |
Member
There was a problem hiding this comment.
Should this comment explicitly say that the file will be truncated?
mattklein123
approved these changes
Feb 3, 2022
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
…9745) Right now Envoy has 2 calls to file based writing, access logs (which append) and the key value store (which is buggy for short writes). We could wire a truncate flag through for k-v store, but I assert most folks want to either append or write-and-truncate, and we can add an InlineWrite flag if folks want !truncate behavior. Risk Level: Medium Testing: new unit test Docs Changes: n/a Release Notes: inline [Optional Runtime guard:] yes Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now Envoy has 2 calls to file based writing, access logs (which append) and the key value store (which is buggy for short writes). We could wire a truncate flag through for k-v store, but I assert most folks want to either append or write-and-truncate, and we can add an InlineWrite flag if folks want !truncate behavior.
Risk Level: Medium
Testing: new unit test
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] yes