tls: SAN with wildcard after string match dns name#19728
Merged
ggreenway merged 10 commits intoenvoyproxy:mainfrom Feb 4, 2022
Merged
tls: SAN with wildcard after string match dns name#19728ggreenway merged 10 commits intoenvoyproxy:mainfrom
ggreenway merged 10 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
@lizan @ggreenway ping, I think this one is awaiting review |
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
lizan
reviewed
Feb 2, 2022
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
lizan
previously approved these changes
Feb 2, 2022
ggreenway
requested changes
Feb 2, 2022
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
lizan
previously approved these changes
Feb 3, 2022
Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
…nvoyproxy#19728) Fixes envoyproxy#18235 Signed-off-by: Sunil Narasimhamurthy <13044744+suniltheta@users.noreply.github.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sunil Narasimhamurthy 13044744+suniltheta@users.noreply.github.com
Commit Message: tls: SAN with wildcard after string match dns name
Additional Description:
Risk Level: Medium
Testing: Updated unit testing
Docs Changes: NA
Release Notes: Included bug fix description
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #18235