Conversation
Was reading through envoyproxy#18531 and seeing the socket address being looked up for each interface confused me a bit, so let's do it only once. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
|
cc: @junr03 |
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
| RELEASE_ASSERT(!rc.return_value_, fmt::format("getiffaddrs error: {}", rc.errno_)); | ||
|
|
||
| absl::optional<std::string> selected_interface_name{}; | ||
| absl::uint128 socket_address_value = socket_address->ip()->version() == Address::IpVersion::v4 |
There was a problem hiding this comment.
I think the prior version would return an empty interface name but I think falling through here might segfault instead. Maybe add a unit test?
|
@rgs1 are you planning on updating with Alyssa's comment? |
|
I think he's out on leave right now, so I assume it'll wait until he gets back |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
3 participants
Was reading through #18531 and seeing the socket address being looked
up for each interface confused me a bit, so let's do it only once.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com