deps: Dump/interpolate repository_locations -> json#19441
Merged
htuch merged 2 commits intoenvoyproxy:mainfrom Jan 11, 2022
Merged
deps: Dump/interpolate repository_locations -> json#19441htuch merged 2 commits intoenvoyproxy:mainfrom
htuch merged 2 commits intoenvoyproxy:mainfrom
Conversation
Member
Author
phlax
force-pushed
the
data-repository_locations
branch
2 times, most recently
from
898db71 to
a4f010b
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
data-repository_locations
branch
from
a4f010b to
ce7f882
Compare
htuch
reviewed
Jan 7, 2022
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
data-repository_locations
branch
from
a27aa29 to
0367f88
Compare
repokitteh-read-only
bot
removed
the
deps
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
There are a few tools that require the repository_locations data, currently we are bringing that data into the python by putting the implementation (as opposed to the abstract library) in the envoy repo, this will allow us to instead pass the repo locations data as a file/cli flag, and move the implementation into the upstream tooling This PR also avoids using the old SourceFileLoader + bzl files method of loading the data, instead loading directly from the write_json rules for the repo files and interpolating There is a more generic implementation of some of what is required here in envoyproxy#17998 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Josh Perry <josh.perry@mx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
There are a few tools that require the repository_locations data, currently we are bringing that data into the python by putting the implementation (as opposed to the abstract library) in the envoy repo, this will allow us to instead pass the repo locations data as a file/cli flag, and move the implementation into the upstream tooling
This PR also avoids using the old
SourceFileLoader+ bzl files method of loading the data, instead loading directly from thewrite_jsonrules for the repo files and interpolatingThere is a more generic implementation of some of what is required here in #17998
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]