Update com_github_nlohmann_json: v3.10.5 (current: v3.10.4)

[kfaseela]

Signed-off-by: Faseela K faseela.k@est.tech

Fixes #19371

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #19384 was opened by kfaseela.

see: more, trace.

[kfaseela]

cc @phlax

[kfaseela]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19384 (comment) was created by @kfaseela.

see: more, trace.

[moderation]

/lgtm deps

[kfaseela]

@phlax review this one?

[phlax]

@kfaseela i think all should be good but im gonna leave it for the assigned maintainer

[alyssawilk]

@wrowe ping!

[alyssawilk]

@kfaseela you OK waiting on merge until late Wednesday? Looks like a year's worth of changes so I'd be inclined to merge after we cut the release.

[kfaseela]

@kfaseela you OK waiting on merge until late Wednesday? Looks like a year's worth of changes so I'd be inclined to merge after we cut the release.

Yes fine for me!

[alyssawilk]

Huh, my compiler is choking on this update.
CI looks fine so arguably I should track down and fix why my env is pickier but generally when I've seen these errors the warning is fairly legit.

In file included from source/common/json/json_internal.cc:19:
In file included from external/com_github_nlohmann_json/include/nlohmann/json.hpp:60:
In file included from external/com_github_nlohmann_json/include/nlohmann/adl_serializer.hpp:6:
In file included from external/com_github_nlohmann_json/include/nlohmann/detail/conversions/from_json.hpp:13:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1215:5: error: exception specification in declaration does not match previous declaration
begin(valarray<_Tp>& __va) noexcept
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/range_access.h:107:31: note: previous declaration is here
template _Tp* begin(valarray<_Tp>&);
^
In file included from source/common/json/json_internal.cc:19:
In file included from external/com_github_nlohmann_json/include/nlohmann/json.hpp:60:
In file included from external/com_github_nlohmann_json/include/nlohmann/adl_serializer.hpp:6:
In file included from external/com_github_nlohmann_json/include/nlohmann/detail/conversions/from_json.hpp:13:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1226:5: error: exception specification in declaration does not match previous declaration
begin(const valarray<_Tp>& __va) noexcept

[moderation]

Hmm. I'm building on Google RBE, Raspberry Pi and MacOS M1 without issue

[RyanTheOptimist]

Huh, my compiler is choking on this update. CI looks fine so arguably I should track down and fix why my env is pickier but generally when I've seen these errors the warning is fairly legit.

@adisuissa @danzh2010 @KBaichoo and I are all seeing the same errors. However after much investigation it definitely appears to be an issue with the local environment. The following .cc file fails to build with clang, but succeeds with gcc:

#include <unordered_map> // unordered_map 
#include <valarray> // valarray
int main(int argc, char** argv) { return 0; }

More investigation needed, but this PR is off the hook.

[adisuissa]

After debugging with @RyanTheOptimist and @KBaichoo (Thanks for the joint debug session!), we think the problem is due to a recent update to the libstdc++-11-dev in our machines to version 11.2.0-12.
It seems that the bug will be solved in the next update (more details here).

For now the workaround is to either build using RBE, or build locally using the --config=clang --config=libc++ bazel flags.