Skip to content

deps/ci: Use envoy.dependency.check#19318

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
phlax:deps-upstream-deps-checker
Feb 4, 2022
Merged

deps/ci: Use envoy.dependency.check#19318
phlax merged 2 commits intoenvoyproxy:mainfrom
phlax:deps-upstream-deps-checker

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Dec 20, 2021

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Dec 20, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #19318 was opened by phlax.

see: more, trace.

@phlax phlax marked this pull request as draft December 20, 2021 09:22
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Dec 20, 2021

testing for envoyproxy/toolshed#143

cc @kfaseela

@mattklein123 mattklein123 removed their assignment Jan 4, 2022
@phlax phlax force-pushed the deps-upstream-deps-checker branch 7 times, most recently from e4dc1ac to dc82d8e Compare January 8, 2022 11:44
@phlax phlax force-pushed the deps-upstream-deps-checker branch 12 times, most recently from 6d68572 to c53d09e Compare January 18, 2022 17:51
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #19318 was synchronize by phlax.

see: more, trace.

@phlax phlax force-pushed the deps-upstream-deps-checker branch from c53d09e to 506223c Compare January 18, 2022 18:02
@phlax phlax removed the api label Jan 18, 2022
@phlax phlax force-pushed the deps-upstream-deps-checker branch 9 times, most recently from 4b3a13b to 96f4e17 Compare January 30, 2022 22:03
@phlax phlax changed the title [WIP] deps: Use upstream deps checker [WIP] deps/ci: Use envoy.dependency.check Jan 30, 2022
@phlax phlax assigned htuch and unassigned adisuissa Jan 30, 2022
@phlax phlax force-pushed the deps-upstream-deps-checker branch from 96f4e17 to a80996f Compare January 30, 2022 22:25
@phlax phlax changed the title [WIP] deps/ci: Use envoy.dependency.check deps/ci: Use envoy.dependency.check Jan 30, 2022
@phlax phlax marked this pull request as ready for review January 30, 2022 22:28
@phlax phlax requested review from htuch and kfaseela January 30, 2022 22:28
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 30, 2022

cc @kfaseela @ME-ON1

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the deps-upstream-deps-checker branch from a80996f to f8bc4ab Compare January 30, 2022 23:03
@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 31, 2022
@ME-ON1
Copy link
Copy Markdown
Contributor

ME-ON1 commented Jan 31, 2022

lgtm just a small query

This action is a scheduled Cron it will not be triggered by a PR event.

  # If this run was triggered by a pull request event, then checkout
  # the head of the pull request instead of the merge commit.
  - run: git checkout HEAD^2
    if: ${{ github.event_name == 'pull_request' }}

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 31, 2022

This action is a scheduled Cron it will not..

yep. thanks @ME-ON1 ive updated the config to be closer to the original

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 3, 2022

@htuch this one is hopefully ready for final review - if you approve it would be good to land myself as i want to watch CI after it lands

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit aa6a397 into envoyproxy:main Feb 4, 2022
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants