Skip to content

test: adding HTTP/3 fail socket write test#19171

Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
alyssawilk:socket_fail_http3
Dec 2, 2021
Merged

test: adding HTTP/3 fail socket write test#19171
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
alyssawilk:socket_fail_http3

Conversation

@alyssawilk
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk commented Dec 2, 2021

Extending the socket override framework to work for HTTP/3 and using it in the failed write test.

Risk Level: n/a (test only)
Testing: yep
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Copy Markdown
Contributor Author

cc @danzh2010 that ended up being more involved than I thought, but I think we can use this for #19144

Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait

testEnvoyProxying1xx(false, false, true);
}

TEST_P(ProtocolIntegrationTest, EnvoyProxying102) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this test pruning intentional?

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Copy Markdown
Contributor Author

/wait

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Copy Markdown
Contributor

@KBaichoo KBaichoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanavlasov yanavlasov merged commit 904f88a into envoyproxy:main Dec 2, 2021
@alyssawilk alyssawilk deleted the socket_fail_http3 branch August 4, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants