Stats: Add iteration and sink predicates for histograms#19166
Stats: Add iteration and sink predicates for histograms#19166jmarantz merged 41 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
pradeepcrao
changed the title
|
/assign jmarantz |
|
/retest |
|
Retrying Azure Pipelines: |
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
looks great modulo some minor nits and one concern about histogram memory growth.
|
/wait |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
Signed-off-by: Pradeep Rao <pcrao@google.com>
Signed-off-by: Pradeep Rao <pcrao@google.com>
jmarantz
added
no stalebot
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
this looks great! Just a few nits.
|
/wait also need to fix format. |
|
@ggreenway will you be able to look at this? |
| // Android. | ||
| FALSE_RUNTIME_GUARD(envoy_reloadable_features_always_use_v6); | ||
| // TODO(pradeepcrao) reset this to true after 2 releases (1.27) | ||
| FALSE_RUNTIME_GUARD(envoy_reloadable_features_enable_include_histograms); |
There was a problem hiding this comment.
Why is a FALSE_RUNTIME_GUARD instead of a RUNTIME_GUARD?
There was a problem hiding this comment.
This disables filtering the histograms by default, so envoy users using sink predicates will not experience histograms silently not being flushed to sinks.
|
@pradeepcrao were you going to pick this up again or should this remain closed? |
|
I missed Greg's comment. Will address this now. |
Signed-off-by: pcrao <pcrao@google.com>
|
CI is failing. Also is the release prediction (1.27) still accurate? /wait |
Qualifying the fix for the CI failure. Given that anyone who has implemented |
Signed-off-by: pcrao <pcrao@google.com>
Signed-off-by: pcrao <pcrao@google.com>
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
@yurykats @stevenzzzz FYI
This still lgtm :)
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: pcrao <pcrao@google.com>
…9166) Commit Message: Additional Description: This is a followup to envoyproxy#18805 that adds the ability to filter histograms to be flushed to sink. Note that this only affects which histograms are flushed and does not change which histograms are merged during every flush operation. Risk Level: Low Testing: Added Tests Docs Changes: N/A Release Notes: included. Platform Specific Features: N/A Signed-off-by: Pradeep Rao <pcrao@google.com> Signed-off-by: VishalDamgude <vishal.damgude@freshworks.com>
5 participants
Commit Message:
Additional Description:
This is a followup to #18805 that adds the ability to filter histograms to be flushed to sink. Note that this only affects which histograms are flushed and does not change which histograms are merged during every flush operation.
Risk Level: Low
Testing: Added Tests
Docs Changes: N/A
Release Notes: included.
Platform Specific Features: N/A