test: fix headerMapEqualIgnoreOrder utility missing a check#19158
Merged
yanavlasov merged 7 commits intoenvoyproxy:mainfrom Dec 2, 2021
Merged
test: fix headerMapEqualIgnoreOrder utility missing a check#19158yanavlasov merged 7 commits intoenvoyproxy:mainfrom
yanavlasov merged 7 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: tangsaidi <tangsaidi@google.com>
Signed-off-by: tangsaidi <tangsaidi@google.com>
tangsaidi
changed the title
Signed-off-by: tangsaidi <tangsaidi@google.com>
Signed-off-by: tangsaidi <tangsaidi@google.com>
Signed-off-by: tangsaidi <tangsaidi@google.com>
Signed-off-by: tangsaidi <tangsaidi@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
The PR should be ready for a first pass review |
yanavlasov
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saidi Tang tangsaidi@google.com
Description: The
headerMapEqualIgnoreOrderfunction didn't check the outcome of theiteratemethod. We are passing a few tests incacheandext_procwith incorrect expected values. I fixed the comparison utility and updated the tests accordingly.Commit Message: Added a flag variable to check whether the iterate function returned after a value mismatch for a key
Risk Level: Low, it's part of the test utility
Testing: Does not apply