matcher: add support for new any matcher mechanism#19143
matcher: add support for new any matcher mechanism#19143snowp merged 7 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Snow Pettersen <snowp@lyft.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
|
Matt is on this, but as he's not available currently I'll assign another first-pass reviewer to push this along. /assign-from @envoyproxy/first-pass-reviewers |
|
@envoyproxy/first-pass-reviewers assignee is @adisuissa |
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Left a couple of minor comments.
/wait
| template <class DataType> using OnMatchFactoryCb = std::function<OnMatch<DataType>()>; | ||
| template <class DataType> using DataInputFactoryCb = std::function<DataInputPtr<DataType>()>; | ||
|
|
||
| template <class DataType> class AnyMatcher : public MatchTree<DataType> { |
There was a problem hiding this comment.
Please add some comments.
| : on_no_match_(std::move(on_no_match)) {} | ||
|
|
||
| typename MatchTree<DataType>::MatchResult match(const DataType&) override { | ||
| return {MatchState::MatchComplete, on_no_match_}; |
There was a problem hiding this comment.
I'm not an expert here, but should the 2nd param (on_no_match_ object) be returned by ref?
There was a problem hiding this comment.
I think in other use cases this always does a copy, since the Action object is generally small (lambda + pointer). We could probably change this around but would be a bigger refactor I think
Signed-off-by: Snow Pettersen <snowp@lyft.com>
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Minor comment on the release notes, but otherwise LGTM.
/assign-from @envoyproxy/senior-maintainers
| New Features | ||
| ------------ | ||
| * http3: downstream HTTP/3 support is now GA! Upstream HTTP/3 also GA for specific deployments. See :ref:`here <arch_overview_http3>` for details. | ||
| * xds: re-introduced unified delta and sotw xDS multiplexers that share most of the implementation. Added a new runtime config ``envoy.reloadable_features.unified_mux`` (disabled by default) that when enabled, switches xDS to use unified multiplexers. |
There was a problem hiding this comment.
Looks like the wrong description
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
4 participants
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Medium
Testing: New UT
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a