Skip to content

tools: Fix dependency checker release dates bug #19109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 1 commit into from
Nov 29, 2021
Merged

tools: Fix dependency checker release dates bug #19109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/dependency/release_dates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def get_tagged_release_date(repo, metadata_version, github_release):
latest = ''
print(f'GithubException {repo.name}: {err.data} {err.status} while getting latest release.')

if latest and github_release.version <= latest.tag_name:
if latest:
Copy link
Copy Markdown
Member Author

@phlax phlax Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moderation im not sure what the logic here is - i would have thought it always wants to return the date of the github_release

release = repo.get_release(github_release.version)
return release.published_at
else:
Expand Down