Skip to content

Update QUICHE from 81314ecbd to c2ddf95dc#19081

Merged
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
RyanTheOptimist:quiche-roll-20211122210552
Nov 23, 2021
Merged

Update QUICHE from 81314ecbd to c2ddf95dc#19081
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
RyanTheOptimist:quiche-roll-20211122210552

Conversation

@RyanTheOptimist
Copy link
Copy Markdown
Contributor

Update QUICHE from 81314ecbd to c2ddf95dc
https://github.com/google/quiche/compare/81314ecbd..c2ddf95dc

$ git log 81314ecbd..c2ddf95dc --date=short --no-merges --format="%ad %al %s"

2021-11-22 quiche-dev Adds an emplace() method to RunOnExit, and deletes the move and copy constructors.
2021-11-22 quiche-dev Makes a safety mechanism related to trailers configurable, and disabled by default.
2021-11-22 haoyuewang Internal change
2021-11-22 haoyuewang Internal change
2021-11-22 fayang Do not reuse tokens received in NEW_TOKEN frames for different connection attempts by: 1) add source address token to QuicClientSessionCache, 2) Clear token after use.
2021-11-19 fayang Add mutable_session_cache() to QuicCryptoClientConfig.
2021-11-19 fayang Move QuicClientSessionCache in chromium to shared code by making following changes: 1) Rename FlushInvalidEntries() and Flush() to RemoveExpiredEntries() and Clear(), respectively. 2) Remove clock_ and SetClockForTesting(), instead, pass in QuicWallTime (use ToUNIXSeconds to get seconds from UNIX epoch because SSL_SESSION_get_time returns seconds from UNIX epoch) to Lookup and RemoveExpiredEntries. 3) Remove memory_pressure_listener_ and OnMemoryPressure(). In chromium, memory_pressure_listener_ and OnMemoryPressure() will be moved to QuicStreamFactory::QuicCryptoClientConfigOwner. 4) Replace base::LRUCache with QuicLRUCache (and add hasher for QuicServerId).
2021-11-19 quiche-dev Move the logic of submitting SETTINGS from OgHttp2Adapter to OgHttp2Session.
2021-11-19 haoyuewang Add QUIC_EXPORT_PRIVATE to RawSha256 method since it is used directly in third_party/quic/quic_transport/web_transport_fingerprint_proof_verifier_test.cc
2021-11-19 fayang Let QuicLRUCache take explicit hasher. Also added various iterators, change Lookup to return iterator and add Erase function.
2021-11-19 quiche-dev Validates that a HEADERS frame with a 100-199 status code does not contain a fin.

Signed-off-by: Ryan Hamilton rch@google.com

Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

https://github.com/google/quiche/compare/81314ecbd..c2ddf95dc

$ git log 81314ecbd..c2ddf95dc --date=short --no-merges --format="%ad %al %s"

2021-11-22 quiche-dev Adds an `emplace()` method to RunOnExit, and deletes the move and copy constructors.
2021-11-22 quiche-dev Makes a safety mechanism related to trailers configurable, and disabled by default.
2021-11-22 haoyuewang Internal change
2021-11-22 haoyuewang Internal change
2021-11-22 fayang Do not reuse tokens received in NEW_TOKEN frames for different connection attempts by: 1) add source address token to QuicClientSessionCache, 2) Clear token after use.
2021-11-19 fayang Add mutable_session_cache() to QuicCryptoClientConfig.
2021-11-19 fayang Move QuicClientSessionCache in chromium to shared code by making following changes: 1) Rename FlushInvalidEntries() and Flush() to RemoveExpiredEntries() and Clear(), respectively. 2) Remove clock_ and SetClockForTesting(), instead, pass in QuicWallTime (use ToUNIXSeconds to get seconds from UNIX epoch because SSL_SESSION_get_time returns seconds from UNIX epoch) to Lookup and RemoveExpiredEntries. 3) Remove memory_pressure_listener_ and OnMemoryPressure(). In chromium, memory_pressure_listener_ and OnMemoryPressure() will be moved to QuicStreamFactory::QuicCryptoClientConfigOwner. 4) Replace base::LRUCache with QuicLRUCache (and add hasher for QuicServerId).
2021-11-19 quiche-dev Move the logic of submitting SETTINGS from OgHttp2Adapter to OgHttp2Session.
2021-11-19 haoyuewang Add QUIC_EXPORT_PRIVATE to RawSha256 method since it is used directly in third_party/quic/quic_transport/web_transport_fingerprint_proof_verifier_test.cc
2021-11-19 fayang Let QuicLRUCache take explicit hasher. Also added various iterators, change Lookup to return iterator and add Erase function.
2021-11-19 quiche-dev Validates that a HEADERS frame with a 100-199 status code does not contain a fin.

Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Hamilton <rch@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 22, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #19081 was opened by RyanTheOptimist.

see: more, trace.

@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

/assign @DavidSchinazi

DavidSchinazi
DavidSchinazi previously approved these changes Nov 22, 2021
Signed-off-by: Ryan Hamilton <rch@google.com>
@RyanTheOptimist
Copy link
Copy Markdown
Contributor Author

/assign @alyssawilk

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 23, 2021
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

@alyssawilk alyssawilk merged commit 400564b into envoyproxy:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants