http: testing failed writes#19021
Merged
alyssawilk merged 5 commits intoenvoyproxy:mainfrom Dec 1, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
cc @danzh2010 |
ggreenway
requested changes
Nov 17, 2021
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
I'm a little bit worried that this test could be flaky. If anything in the process opens a file descriptor for any reason after close(), the fd could become valid again and result in unexpected behavior.
Another possible way to test would be to set a mock API that returns EINVAL or something from syscalls just for this one fd.
|
|
||
| // Touches raw sockets. | ||
| #ifndef WIN32 | ||
| TEST_P(DownstreamProtocolIntegrationTest, HandleSocketFail) { |
Member
There was a problem hiding this comment.
Comment on what this is testing?
| class OnSocketFailFilter : public Http::PassThroughFilter { | ||
| public: | ||
| Http::FilterHeadersStatus encodeHeaders(Http::ResponseHeaderMap&, bool) override { | ||
| close(fd()); |
Member
There was a problem hiding this comment.
Add comment on why this doesn't call ioHandle()->close() (so that IoHandle doesn't know the fd is invalid).
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: n/a (test only)
Testing: new integration test
Docs Changes: n/a
Release Notes: n/a