stream_info: reworking upstream data#19020
Merged
mattklein123 merged 9 commits intoenvoyproxy:mainfrom Nov 19, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
commented
Nov 16, 2021
Contributor
Author
|
/wait on merge conflicts |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
mattklein123
previously approved these changes
Nov 17, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM. Is there any reason to not just do the larger cleanup as part of this PR?
Contributor
Author
|
I've got the "removing setter" PR mostly written, but it's somewhat higher risk as it changes when a bunch of things are set, so I suspect it may take some time to land. I definitely prefer to land this and update envoy mobile to move away from the getters before removing the getters. |
mattklein123
previously approved these changes
Nov 17, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring upstream stream info into a shared pointer owned struct.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Refactors for envoyproxy/envoy-mobile#1520