lua: support body setBytes with header content length set automatically#18989
lua: support body setBytes with header content length set automatically#18989yanavlasov merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wangkai19 <wangkai19@corp.netease.com>
|
Hi @StarryVae, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
cc @dio |
Signed-off-by: wangkai19 <wangkai19@corp.netease.com>
Signed-off-by: wangkai19 <wangkai19@corp.netease.com>
Signed-off-by: wangkai19 <wangkai19@corp.netease.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
@dio PTAL :) |
There was a problem hiding this comment.
@StarryVae Thank you for working on this. A good idea really. Could you update the docs as well? Currently, we have a sample requiring setting the content-length post modifying the content.
Signed-off-by: wangkai19 <wangkai19@corp.netease.com>
@dio done, PTAL again, thank you! |
|
@dio @lizan @yanavlasov It seems that this patch is blocked by "First-time contributors need a maintainer to approve running workflows" ? please help, thank you! |
* main: Stats: Filter stats to be flushed to sinks (envoyproxy#18805) build(deps): bump sphinx from 4.3.0 to 4.3.1 in /tools/base (envoyproxy#19122) ext-authz: fix missing UAEX flag on Denied CheckResponse (envoyproxy#18965) lua: support body setBytes with header content length set automatically (envoyproxy#18989) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
5 participants
Signed-off-by: wangkai19 wangkai19@corp.netease.com
Commit Message: This patch modifies body setBytes API to make the header content length can be set automatically, which can avoid error when you forget set header content length in lua script and make the setBytes API more convenient for users.
Risk Level: Low
Testing: ut, integration
Docs Changes: N/A