stream_info: moving downstream timing into its own class#18967
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Nov 15, 2021
Merged
stream_info: moving downstream timing into its own class#18967alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
Contributor
Author
|
/wait |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
downstream_timing
branch
from
f224fe1 to
c6a4ff5
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
zuercher
approved these changes
Nov 12, 2021
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Looks good. Just had one question.
| } | ||
|
|
||
| private: | ||
| absl::flat_hash_map<std::string, MonotonicTime> timings_; |
Member
There was a problem hiding this comment.
I don't see where this is used. Is it for a follow-on change?
Contributor
Author
There was a problem hiding this comment.
indeed, sorry I failed to clean up here, it's part of #18934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to #18934
Risk Level: low (refactor)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Part of envoyproxy/envoy-mobile#1520