remove unnecessary std::string in source#18948
Merged
yanavlasov merged 7 commits intoenvoyproxy:mainfrom Nov 16, 2021
Merged
Conversation
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
@yanavlasov can you take a another look i have updated this PR and will also add few more if this works. Also the test which are failing in azure CI is passing locally, do we have to run it again ? |
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
yanavlasov
approved these changes
Nov 12, 2021
yanavlasov
requested changes
Nov 12, 2021
Contributor
yanavlasov
left a comment
yanavlasov
left a comment
There was a problem hiding this comment.
You may also want to merge main to pick up fixes for a flaky test.
Contributor
|
/wait |
Signed-off-by: Tarun Sharma <starun.1998@gmail.com>
Signed-off-by: Tarun Sharma <starun.1998@gmail.com>
Co-authored-by: yanavlasov <yavlasov@google.com> Signed-off-by: Tarun Sharma <starun.1998@gmail.com>
Co-authored-by: yanavlasov <yavlasov@google.com> Signed-off-by: Tarun Sharma <starun.1998@gmail.com>
Signed-off-by: Tarun Sharma <starun.1998@gmail.com>
Member
|
/retest |
|
Retrying Azure Pipelines: |
rojkov
approved these changes
Nov 16, 2021
Member
rojkov
left a comment
rojkov
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me.
Deferring to @yanavlasov for a final pass and merge.
yanavlasov
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tarun Sharma starun.1998@gmail.com
#11318
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]