access_log: Added new command operator %VIRTUAL_CLUSTER_NAME% to retrieve the matched VC name by agrawroh · Pull Request #18941 · envoyproxy/envoy

agrawroh · 2021-11-09T03:51:43Z

This PR adds a new command operator in the access logs called %VIRTUAL_CLUSTER_NAME% which can be used to retrieve the matched Virtual Cluster name information.

It could be very useful for understanding which Virtual Cluster is getting matched for a given route especially when we have thousands of routes and a subset of Virtual Clusters.

Commit Message: Added new command operator %VIRTUAL_CLUSTER_NAME% to retrieve the matched VC name
Additional Description: Adds a new command operator called %VIRTUAL_CLUSTER_NAME% in the access logs which can be used to retrieve the matched Virtual Cluster name for the incoming request. It gets populated from the Router.
Risk Level: Low
Testing: Unit Tests
Docs Changes: Added description on %VIRTUAL_CLUSTER_NAME% in the Docs.
Release Notes: Added
Platform Specific Features: N/A

Signed-off-by: Rohit Agrawal rohit.agrawal@databricks.com

…ieve the matched VC name Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

agrawroh · 2021-11-11T00:04:49Z

/retest

repokitteh-read-only · 2021-11-11T00:04:53Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18941 (comment) was created by @agrawroh.

see: more, trace.

agrawroh · 2021-11-11T00:47:57Z

/retest

repokitteh-read-only · 2021-11-11T00:48:00Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18941 (comment) was created by @agrawroh.

see: more, trace.

lambdai

Generally LGTM modulo minor nits

source/common/formatter/substitution_formatter.cc

docs/root/configuration/observability/access_log/usage.rst

source/common/router/router.cc

…o-access-logs Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

agrawroh · 2021-11-16T22:42:38Z

/retest

repokitteh-read-only · 2021-11-16T22:42:42Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18941 (comment) was created by @agrawroh.

see: more, trace.

ggreenway · 2021-11-17T17:12:59Z

/wait

…o-access-logs Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

…o-access-logs

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

…o-access-logs

agrawroh · 2021-11-18T23:20:27Z

/retest

repokitteh-read-only · 2021-11-18T23:20:30Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18941 (comment) was created by @agrawroh.

see: more, trace.

agrawroh · 2021-11-19T04:47:46Z

/retest

repokitteh-read-only · 2021-11-19T04:47:51Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18941 (comment) was created by @agrawroh.

see: more, trace.

source/common/router/config_impl.h

source/common/router/router.cc

source/common/stream_info/stream_info_impl.h

jmarantz

/wait

…o-access-logs

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

…o-access-logs

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

jmarantz

looks great -- just a few minor nits

docs/root/configuration/observability/access_log/usage.rst

source/common/router/config_impl.h

source/common/stream_info/stream_info_impl.h

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

jmarantz

/assign-from @envoyproxy/senior-maintainers

repokitteh-read-only · 2021-11-22T14:03:36Z

@envoyproxy/senior-maintainers assignee is @zuercher

🐱

Caused by: a #18941 (review) was submitted by @jmarantz.

see: more, trace.

zuercher

Sorry for the slow response, I was out last week. Just one comment below.

source/common/formatter/substitution_formatter.cc

…o-access-logs

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

zuercher

Thanks!

agrawroh added 2 commits November 8, 2021 22:47

access_log: Added new command operator %VIRTUAL_CLUSTER_NAME% to retr…

c0e451b

…ieve the matched VC name Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Fixed Tests

338e117

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

yanavlasov assigned ggreenway Nov 10, 2021

agrawroh added 2 commits November 10, 2021 15:45

Merge branch 'main' into add-vc-name-to-access-logs

2afee97

Fixed Formatter Test

6aa15e8

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

agrawroh force-pushed the add-vc-name-to-access-logs branch from abe455d to 6aa15e8 Compare November 10, 2021 21:40

lambdai reviewed Nov 11, 2021

View reviewed changes

source/common/formatter/substitution_formatter.cc Outdated Show resolved Hide resolved

docs/root/configuration/observability/access_log/usage.rst Show resolved Hide resolved

lambdai reviewed Nov 12, 2021

View reviewed changes

source/common/router/router.cc Outdated Show resolved Hide resolved

ggreenway added the waiting label Nov 15, 2021

agrawroh added 2 commits November 15, 2021 18:03

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

ef45a22

…o-access-logs Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Addressed Comments From @lambdai

2037455

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

repokitteh-read-only bot removed the waiting label Nov 15, 2021

agrawroh requested a review from lambdai November 15, 2021 23:11

agrawroh added 2 commits November 16, 2021 12:47

Merge branch 'main' into add-vc-name-to-access-logs

70e6cdf

Resolved Merge Conflicts

6735c98

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

repokitteh-read-only bot added the waiting label Nov 17, 2021

agrawroh added 2 commits November 17, 2021 15:36

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

258a0ff

…o-access-logs Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Addressed Comments From @jmarantz

d7d782c

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

repokitteh-read-only bot removed the waiting label Nov 17, 2021

ggreenway assigned jmarantz and unassigned ggreenway Nov 17, 2021

agrawroh added 2 commits November 17, 2021 17:47

Remove Unwanted Fields

18b19f0

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

1d01999

…o-access-logs

agrawroh added 2 commits November 18, 2021 17:56

Addressed Comments From @jmarantz

73bb998

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

341aaf7

…o-access-logs

agrawroh requested a review from jmarantz November 18, 2021 22:57

jmarantz reviewed Nov 19, 2021

View reviewed changes

source/common/router/config_impl.h Outdated Show resolved Hide resolved

source/common/router/router.cc Outdated Show resolved Hide resolved

source/common/stream_info/stream_info_impl.h Outdated Show resolved Hide resolved

jmarantz reviewed Nov 19, 2021

View reviewed changes

repokitteh-read-only bot added the waiting label Nov 19, 2021

agrawroh added 3 commits November 19, 2021 09:48

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

fb141c1

…o-access-logs

Addressed Comments From @jmarantz

073fdb6

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

a3342e7

…o-access-logs

repokitteh-read-only bot removed the waiting label Nov 20, 2021

agrawroh force-pushed the add-vc-name-to-access-logs branch 2 times, most recently from 4635bf6 to 5f3c0f3 Compare November 21, 2021 04:04

Fix Syntax

d4eb829

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

agrawroh force-pushed the add-vc-name-to-access-logs branch from 5f3c0f3 to d4eb829 Compare November 21, 2021 06:11

jmarantz reviewed Nov 21, 2021

View reviewed changes

docs/root/configuration/observability/access_log/usage.rst Outdated Show resolved Hide resolved

source/common/router/config_impl.h Outdated Show resolved Hide resolved

source/common/stream_info/stream_info_impl.h Outdated Show resolved Hide resolved

Addressed Comments From @jmarantz

0dee63c

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

jmarantz previously approved these changes Nov 22, 2021

View reviewed changes

repokitteh-read-only bot assigned zuercher Nov 22, 2021

zuercher requested changes Nov 29, 2021

View reviewed changes

source/common/formatter/substitution_formatter.cc Outdated Show resolved Hide resolved

agrawroh added 2 commits November 29, 2021 14:24

Merge branch 'main' of github.com:envoyproxy/envoy into add-vc-name-t…

ad17748

…o-access-logs

Addressed Comments From @zuercher

325cf76

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

agrawroh dismissed jmarantz’s stale review via 325cf76 November 29, 2021 19:46

agrawroh requested a review from zuercher November 29, 2021 19:47

zuercher approved these changes Nov 29, 2021

View reviewed changes

mattklein123 merged commit c716ec6 into envoyproxy:main Nov 30, 2021

Conversation

agrawroh commented Nov 9, 2021

Uh oh!

agrawroh commented Nov 11, 2021

Uh oh!

repokitteh-read-only bot commented Nov 11, 2021

Uh oh!

agrawroh commented Nov 11, 2021

Uh oh!

repokitteh-read-only bot commented Nov 11, 2021

Uh oh!

lambdai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agrawroh commented Nov 16, 2021

Uh oh!

repokitteh-read-only bot commented Nov 16, 2021

Uh oh!

ggreenway commented Nov 17, 2021

Uh oh!

agrawroh commented Nov 18, 2021

Uh oh!

repokitteh-read-only bot commented Nov 18, 2021

Uh oh!

agrawroh commented Nov 19, 2021

Uh oh!

repokitteh-read-only bot commented Nov 19, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmarantz left a comment

Choose a reason for hiding this comment

Uh oh!

jmarantz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmarantz left a comment

Choose a reason for hiding this comment

Uh oh!

repokitteh-read-only bot commented Nov 22, 2021

Uh oh!

zuercher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zuercher left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants