Skip to content

test: fixing a test flake #18899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanavlasov merged 5 commits into from
Nov 9, 2021
Merged

test: fixing a test flake #18899

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3684de9
test: fixing a test flake
alyssawilk Nov 4, 2021
eae2700
Merge branch 'main' into flake
alyssawilk Nov 4, 2021
94cc83b
merge fix
alyssawilk Nov 4, 2021
87b31f9
Merge branch 'main' into flake
alyssawilk Nov 8, 2021
e5272f0
Merge branch 'main' into flake
alyssawilk Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/integration/multiplexed_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1920,9 +1920,8 @@ TEST_P(MultiplexedIntegrationTest, OnLocalReply) {
}
}

// Disabled for coverage temporarily see #18881
#if !defined(ENVOY_CONFIG_COVERAGE)
TEST_P(MultiplexedIntegrationTest, InvalidTrailers) {
autonomous_allow_incomplete_streams_ = true;
useAccessLog("%RESPONSE_CODE_DETAILS%");
autonomous_upstream_ = true;
initialize();
Expand All @@ -1941,7 +1940,6 @@ TEST_P(MultiplexedIntegrationTest, InvalidTrailers) {
// http2.invalid.header.field or http3.invalid_header_field
EXPECT_THAT(waitForAccessLog(access_log_name_), HasSubstr("invalid"));
}
#endif

TEST_P(MultiplexedIntegrationTest, InconsistentContentLength) {
useAccessLog("%RESPONSE_CODE_DETAILS%");
Expand Down