Skip to content

quic: post-import TODO cleanup #18898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanTheOptimist merged 1 commit into from
Nov 4, 2021
Merged

quic: post-import TODO cleanup #18898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions source/common/quic/envoy_quic_client_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,6 @@

#include "quic_filter_manager_connection_impl.h"

namespace quic {
namespace test {

// TODO(alyssawilk) add the necessary accessors to quiche and remove this.
class QuicSessionPeer {
public:
static quic::QuicStreamIdManager&
getStreamIdManager(Envoy::Quic::EnvoyQuicClientSession* session) {
return session->ietf_streamid_manager_.bidirectional_stream_id_manager_;
}
};

} // namespace test
} // namespace quic

namespace Envoy {
namespace Quic {

Expand Down Expand Up @@ -135,9 +120,11 @@ quic::QuicConnection* EnvoyQuicClientSession::quicConnection() {
}

uint64_t EnvoyQuicClientSession::streamsAvailable() {
quic::QuicStreamIdManager& manager = quic::test::QuicSessionPeer::getStreamIdManager(this);
ASSERT(manager.outgoing_max_streams() >= manager.outgoing_stream_count());
uint32_t streams_available = manager.outgoing_max_streams() - manager.outgoing_stream_count();
const quic::UberQuicStreamIdManager& manager = ietf_streamid_manager();
ASSERT(manager.max_outgoing_bidirectional_streams() >=
manager.outgoing_bidirectional_stream_count());
uint32_t streams_available =
manager.max_outgoing_bidirectional_streams() - manager.outgoing_bidirectional_stream_count();
return streams_available;
}

Expand Down