Update QUICHE from 1e04d1e30 to 0b75841d5#18862
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Nov 3, 2021
Merged
Conversation
https://github.com/google/quiche/compare/1e04d1e30..0b75841d5 $ git log 1e04d1e30..0b75841d5 --date=short --no-merges --format="%ad %al %s" 2021-11-01 dschinazi Internal change 2021-11-01 dschinazi Platformize AsciiUrlDecode 2021-11-01 wub Pass ParsedClientHello to QuicDispatcher::CreateQuicSession. This makes it easier to pass CHLO information into CreateQuicSession, which is responsible for creating a QUIC session. 2021-11-01 wub Deprecate --gfe2_reloadable_flag_quic_tls_disable_resumption_refactor. 2021-11-01 haoyuewang Internal change Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
RyanTheOptimist
previously approved these changes
Nov 2, 2021
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Looks great modulo one nit.
(I love seeing a summary of QUICHE changes in the PR description!)
| absl::string_view alpn, | ||
| const quic::ParsedQuicVersion& version, | ||
| absl::string_view sni) override; | ||
| const quic::ParsedClientHello& sni) override; |
Contributor
There was a problem hiding this comment.
nit: "sni" => "parsed_chlo"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/google/quiche/compare/1e04d1e30..0b75841d5
$ git log 1e04d1e30..0b75841d5 --date=short --no-merges --format="%ad %al %s"
2021-11-01 dschinazi Internal change
2021-11-01 dschinazi Platformize AsciiUrlDecode
2021-11-01 wub Pass ParsedClientHello to QuicDispatcher::CreateQuicSession. This makes it easier to pass CHLO information into CreateQuicSession, which is responsible for creating a QUIC session.
2021-11-01 wub Deprecate --gfe2_reloadable_flag_quic_tls_disable_resumption_refactor.
2021-11-01 haoyuewang Internal change
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a